From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoHmD-000149-FF for qemu-devel@nongnu.org; Fri, 20 Jan 2012 11:57:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RoHmB-0001B7-6v for qemu-devel@nongnu.org; Fri, 20 Jan 2012 11:57:21 -0500 Received: from smtp121.dfw.emailsrvr.com ([67.192.241.121]:37736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoHmA-0001B1-Qu for qemu-devel@nongnu.org; Fri, 20 Jan 2012 11:57:19 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp22.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id A39E9170C7F for ; Fri, 20 Jan 2012 11:57:15 -0500 (EST) Received: by smtp22.relay.dfw1a.emailsrvr.com (Authenticated sender: mark.langsdorf-AT-calxeda.com) with ESMTPSA id 8F457170CB6 for ; Fri, 20 Jan 2012 11:57:15 -0500 (EST) Message-ID: <4F199CEB.3050003@calxeda.com> Date: Fri, 20 Jan 2012 10:57:15 -0600 From: Mark Langsdorf MIME-Version: 1.0 References: <1326213943-878-1-git-send-email-mark.langsdorf@calxeda.com> <1327008660-16789-1-git-send-email-mark.langsdorf@calxeda.com> <1327008660-16789-5-git-send-email-mark.langsdorf@calxeda.com> <4F18A475.80009@calxeda.com> <4F197099.2020708@calxeda.com> <4F199576.1070701@calxeda.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 4/4] arm: SoC model for Calxeda Highbank List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 01/20/2012 10:27 AM, Peter Maydell wrote: > On 20 January 2012 16:25, Mark Langsdorf wrote: >> On 01/20/2012 07:48 AM, Rob Herring wrote: >>> On 01/20/2012 02:47 AM, Peter Maydell wrote: >>>> On 19 January 2012 23:17, Rob Herring wrote: >>>>> On 01/19/2012 03:44 PM, Peter Maydell wrote: >>>>>> On 19 January 2012 21:31, Mark Langsdorf wrote: >>>>>>> + highbank_binfo.board_id = 0xEC10100f; /* provided by deviceTree */ >>>>>> >>>>>> Where does this number come from? It's not in >>>>>> http://www.arm.linux.org.uk/developer/machines/ >>>>>> >>>>>> Is 3027 (==0xbd3) you? >>>>>> http://www.arm.linux.org.uk/developer/machines/list.php?id=3027 >>>>>> >>>>> >>>>> Much of the data there is wrong as none of it is used. 0 or -1 is the >>>>> right value as those are obviously meaningless. A highbank kernel will >>>>> never be booted without devicetree and in that case this number is >>>>> irrelevant. This is the legacy boot interface and qemu really needs to >>>>> learn to boot with a separate dtb. >>>> >>>> Yeah, but the documentation even for DTB boot says we should pass >>>> in a machine number. If 0 or -1 are right then there should be >>>> some documentation that says so. I'll accept "mailing list post >>>> from some authoritative person [eg Grant Likely]" if necessary. >>> >>> Kernel DT co-maintainer is not authoritative enough for you? >> >> Peter, is that sufficient for me to send in the patch with a >> board_id of -1? Thanks. > > It's still not clear to me from this conversation if the right > answer is "0", "-1" or "anything that's not a valid board ID > and not -1 either"... Quoting Rob from upthread: "0 or -1 is the right value as those are obviously meaningless." The original code that Rob wrote had a board_id of -1. That's the right answer. --Mark Langsdorf Calxeda, Inc.