From: "Andreas Färber" <afaerber@suse.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 02/14] target-sparc: Fix mixup of uint64 and uint64_t
Date: Sun, 22 Jan 2012 03:03:52 +0100 [thread overview]
Message-ID: <4F1B6E88.7090606@suse.de> (raw)
In-Reply-To: <CAAu8pHsRTR7q-RfSjpFwX7AC+7mf+gLozUOwmog4jC6KJtuoEQ@mail.gmail.com>
Am 21.01.2012 19:51, schrieb Blue Swirl:
> On Mon, Jan 16, 2012 at 00:46, Andreas Färber <afaerber@suse.de> wrote:
>> Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc:
>> Implement BMASK/BSHUFFLE.) introduced a stray usage of softfloat uint64
>> type.
>>
>> Use uint64_t instead.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> Cc: Richard Henderson <rth@twiddle.net>
>> Cc: Blue Swirl <blauwirbel@gmail.com>
>
> Good catch,
> Reviewed-by: Blue Swirl <blauwirbel@gmail.com>
Feel free to apply this patch if Richard doesn't comment. The rest of
the series needs some more review and benchmarking.
Is there maybe a way to poison these types outside fpu/ meanwhile?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-01-22 2:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 0:46 [Qemu-devel] [PATCH 00/14] softfloat: Use POSIX integer types - benchmarked Andreas Färber
2012-01-16 0:46 ` [Qemu-devel] [PATCH 01/14] lm32: Fix mixup of uint32 and uint32_t Andreas Färber
2012-01-16 11:27 ` Peter Maydell
2012-01-16 12:18 ` Andreas Färber
2012-01-16 21:39 ` Michael Walle
2012-01-17 9:44 ` [Qemu-devel] [PATCH v2] " Andreas Färber
2012-01-19 8:17 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-01-16 0:46 ` [Qemu-devel] [PATCH 02/14] target-sparc: Fix mixup of uint64 and uint64_t Andreas Färber
2012-01-21 18:51 ` Blue Swirl
2012-01-22 2:03 ` Andreas Färber [this message]
2012-01-22 8:09 ` Blue Swirl
2012-01-22 10:02 ` Blue Swirl
2012-01-16 0:46 ` [Qemu-devel] [PATCH 03/14] qemu-tool: Fix mixup of int64 and int64_t Andreas Färber
2012-01-16 8:11 ` Stefan Hajnoczi
2012-01-16 0:46 ` [Qemu-devel] [PATCH 04/14] softfloat: Fix mixups of int and int16 Andreas Färber
2012-01-16 17:51 ` Peter Maydell
2012-01-16 0:46 ` [Qemu-devel] [PATCH 05/14] target-mips: Move definition of uint_fast{8, 16}_t to osdep.h Andreas Färber
2012-01-16 11:38 ` Peter Maydell
2012-01-16 12:13 ` Andreas Färber
2012-01-16 12:21 ` Peter Maydell
2012-01-16 12:24 ` Andreas Färber
2012-01-16 0:46 ` [Qemu-devel] [PATCH 06/14] softfloat: Replace uint16 type with uint_fast16_t Andreas Färber
2012-01-16 18:43 ` Peter Maydell
2012-01-16 0:46 ` [Qemu-devel] [PATCH 07/14] softfloat: Replace int16 type with int_fast16_t Andreas Färber
2012-01-16 0:46 ` [Qemu-devel] [PATCH 08/14] softfloat: Remove unused uint8 type Andreas Färber
2012-01-16 0:46 ` [Qemu-devel] [PATCH 09/14] softfloat: Replace int8 type with int_fast8_t Andreas Färber
2012-01-16 18:48 ` Peter Maydell
2012-01-16 0:46 ` [Qemu-devel] [PATCH 10/14] softfloat: Replace uint32 type with uint_fast32_t Andreas Färber
2012-01-16 0:47 ` [Qemu-devel] [PATCH 11/14] softfloat: Replace int32 type with int_fast32_t Andreas Färber
2012-01-16 0:47 ` [Qemu-devel] [PATCH 12/14] softfloat: Replace uint64 type with uint_fast64_t Andreas Färber
2012-01-16 0:47 ` [Qemu-devel] [PATCH 13/14] softfloat: Replace int64 type with int_fast64_t Andreas Färber
2012-01-16 0:47 ` [Qemu-devel] [PATCH 14/14] softfloat: Replace flag type with bool Andreas Färber
2012-01-16 19:02 ` [Qemu-devel] [PATCH 00/14] softfloat: Use POSIX integer types - benchmarked Peter Maydell
2012-01-16 19:12 ` Alexander Graf
2012-01-16 19:17 ` Peter Maydell
2012-01-16 19:18 ` Alexander Graf
2012-01-16 23:52 ` Peter Maydell
2012-01-17 0:05 ` Alexander Graf
2012-01-20 13:05 ` Peter Maydell
2012-01-23 17:41 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1B6E88.7090606@suse.de \
--to=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).