From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rp910-0002e1-Ip for qemu-devel@nongnu.org; Sun, 22 Jan 2012 20:48:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rp90z-0005h8-5s for qemu-devel@nongnu.org; Sun, 22 Jan 2012 20:48:10 -0500 Received: from mail-yw0-f45.google.com ([209.85.213.45]:46943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rp90z-0005h4-26 for qemu-devel@nongnu.org; Sun, 22 Jan 2012 20:48:09 -0500 Received: by yhr47 with SMTP id 47so1291847yhr.4 for ; Sun, 22 Jan 2012 17:48:08 -0800 (PST) Message-ID: <4F1CBC56.4020508@codemonkey.ws> Date: Sun, 22 Jan 2012 19:48:06 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <4F1B0C3E.20905@landley.net> <4F1BB581.6030703@weilnetz.de> <4F1C9EF5.9090105@landley.net> In-Reply-To: <4F1C9EF5.9090105@landley.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Commit 5632ae46 broke the network on mips. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rob Landley Cc: Stefan Weil , qemu-devel On 01/22/2012 05:42 PM, Rob Landley wrote: > On 01/22/2012 01:06 AM, Stefan Weil wrote: >> Am 21.01.2012 20:04, schrieb Rob Landley: >>> commit 5632ae46: "mips_malta: move i8259 initialization after piix4 >>> initialization" broke the network on mips. It still comes up, but >>> doesn't pass packets. >>> >>> Try this: >>> >>> wget http://landley.net/aboriginal/bin/system-image-mips.tar.bz2 >>> tar xvjf system-image-mips.tar.bz2 >>> cd system-image-mips >>> ./run-emulator.sh >>> >>> [ wait for shell prompt ] >>> >>> wget http://google.com >>> >>> Under 0.15.1 it works, under 1.0 it doesn't. Identical binary. I >>> bisected it to the commit in question, it's still broken in -master. >>> >>> Rob >> >> This was fixed with commits e9b40fd34ceb23461083d505a444a389c094455b >> and 0b23c5d40ea933cfece3b4f69427f79c8a23256d in master and stable-1.0. > > The git tag for v1.0 does not include that commit. Apparently the > current 1.0 tarball on the website does, which is odd since e9b4 was > only applied to the git tree _after_ a January 6th commit. So either > "git log" is being weird, or you guys retroactively re-released the 1.0 > tarball without renumbering it? > > I'm confused... > >> My latest QEMU works with MIPS Malta running from an NFS root. > > I can confirm that current -master works for me. > > The 1.0 tarball includes the fix, the 1.0 git tag doesn't. I'll include > a note to that effect in my release notes. BTW, since you tag doesn't have this changeset (and it should), it's your tag that's messed up. Fortunately, for the 1.0 release, I started using a signed tag. http://git.qemu.org/?p=qemu.git;a=tag;h=5e5e6d6c16e1742996d93e8f3e946cf544d0b146 So this should help you figure out where your bogus tag came from. Regards, Anthony Liguori > > Thanks, > > Rob >