From: "Hervé Poussineau" <hpoussin@reactos.org>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 04/10] fdc: emulate stepping 0
Date: Mon, 23 Jan 2012 08:58:48 +0100 [thread overview]
Message-ID: <4F1D1338.1080402@reactos.org> (raw)
In-Reply-To: <4F13F3D3.9010200@redhat.com>
Hi,
Kevin Wolf a écrit :
> Am 15.01.2012 08:51, schrieb Hervé Poussineau:
>> Stepping 1 (S82078B) is not fully i82078 compatible, so better stick to initial revision
>>>
> Hm, this is the kind of change that I'm hesitant to make because I don't
> understand the implications. Can you give some more details what is
> fixed by this and why you think it's harmless for currently working OSes?
>
I was thinking at comments like
https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=blob;f=drivers/char/ftape/lowlevel/fdc-io.c;h=65c9d2ec60bdd7221a30a776fba377c37b89c078;hb=refs/heads/linux-2.6.18.y#l1119
Anyway, I didn't see any real problem yet with current code.
I'll resend this serie without this patch.
Regards
Hervé
next prev parent reply other threads:[~2012-01-23 7:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 7:51 [Qemu-devel] [PATCH v2 00/10] Misc fixes for floppy emulation Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 01/10] fdc: take side count into account Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 02/10] fdc: set busy bit when starting a command Hervé Poussineau
2012-01-16 9:33 ` Kevin Wolf
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 03/10] fdc: most control commands do not generate interrupts Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 04/10] fdc: emulate stepping 0 Hervé Poussineau
2012-01-16 9:54 ` Kevin Wolf
2012-01-23 7:58 ` Hervé Poussineau [this message]
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 05/10] fdc: handle read-only floppies (abort early on write commands) Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 06/10] fdc: add CCR (Configuration Control Register) write register Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 07/10] block: add a transfer rate for floppy types Hervé Poussineau
2012-01-16 10:18 ` Kevin Wolf
2012-01-21 19:02 ` Blue Swirl
2012-01-23 8:51 ` Kevin Wolf
2012-01-23 16:56 ` Blue Swirl
2012-01-27 8:33 ` Markus Armbruster
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 08/10] fdc: check if media rate is correct before doing any transfer Hervé Poussineau
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 09/10] fdc: fix seek command, which shouldn't check tracks Hervé Poussineau
2012-01-16 10:32 ` Kevin Wolf
2012-01-15 7:51 ` [Qemu-devel] [PATCH v2 10/10] fdc: DIR (Digital Input Register) should return status of current drive Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1D1338.1080402@reactos.org \
--to=hpoussin@reactos.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).