From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpEnt-0004wQ-U0 for qemu-devel@nongnu.org; Mon, 23 Jan 2012 02:59:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpEnt-00007x-01 for qemu-devel@nongnu.org; Mon, 23 Jan 2012 02:59:01 -0500 Received: from smtp1-g21.free.fr ([212.27.42.1]:59131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpEns-00005t-8W for qemu-devel@nongnu.org; Mon, 23 Jan 2012 02:59:00 -0500 Message-ID: <4F1D1338.1080402@reactos.org> Date: Mon, 23 Jan 2012 08:58:48 +0100 From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= MIME-Version: 1.0 References: <1326613915-3282-1-git-send-email-hpoussin@reactos.org> <1326613915-3282-5-git-send-email-hpoussin@reactos.org> <4F13F3D3.9010200@redhat.com> In-Reply-To: <4F13F3D3.9010200@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 04/10] fdc: emulate stepping 0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Hi, Kevin Wolf a =C3=A9crit : > Am 15.01.2012 08:51, schrieb Herv=C3=A9 Poussineau: >> Stepping 1 (S82078B) is not fully i82078 compatible, so better stick t= o initial revision >>>=20 > Hm, this is the kind of change that I'm hesitant to make because I don'= t > understand the implications. Can you give some more details what is > fixed by this and why you think it's harmless for currently working OSe= s? >=20 I was thinking at comments like https://git.kernel.org/?p=3Dlinux/kernel/git/stable/linux-stable.git;a=3D= blob;f=3Ddrivers/char/ftape/lowlevel/fdc-io.c;h=3D65c9d2ec60bdd7221a30a77= 6fba377c37b89c078;hb=3Drefs/heads/linux-2.6.18.y#l1119 Anyway, I didn't see any real problem yet with current code. I'll resend this serie without this patch. Regards Herv=C3=A9