From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52454)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1RpIa0-0004GB-MN
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 07:01:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1RpIZv-0005bb-0g
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 07:00:56 -0500
Received: from smtp1-g21.free.fr ([212.27.42.1]:47846)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1RpIZu-0005Xe-9t
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 07:00:50 -0500
Message-ID: <4F1D4BEB.3040904@reactos.org>
Date: Mon, 23 Jan 2012 13:00:43 +0100
From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
MIME-Version: 1.0
References: <1327310329-15294-1-git-send-email-hpoussin@reactos.org>
	<4F1D428A.1050005@siemens.com>
In-Reply-To: <4F1D428A.1050005@siemens.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] rtc: initialize irq even if caller doesn't
 use rtc_init() function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Jan Kiszka a =C3=A9crit :
> On 2012-01-23 10:18, Herv=C3=A9 Poussineau wrote:
>> rtc instanciated with -device has now a working irq line
>=20
> That makes no sense. The mc146818rtc is no_user - for a reason.
>=20
> What is the use case you are trying to address?
>=20

I wanted to be able to instanciate it with isa_create_simple(isa_bus,=20
"mc146818rtc") in machine init code.
I don't see any good reason why a rtc created this way can't work.

The commit message can be changed to:
"rtc: initialize irq even if caller doesn't use rtc_init() function
rtc instancianted with isa_create_simple() has now a working irq line"
if you prefer...

Herv=C3=A9