From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38110)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RpLEt-0005Xu-PN
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 09:51:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RpLEs-0003vZ-HM
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 09:51:19 -0500
Received: from mx1.redhat.com ([209.132.183.28]:61693)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RpLEs-0003vU-9C
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 09:51:18 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0NEpGjm030604
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 23 Jan 2012 09:51:16 -0500
Message-ID: <4F1D73E2.5000100@redhat.com>
Date: Mon, 23 Jan 2012 15:51:14 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1326385868-26538-1-git-send-email-hdegoede@redhat.com>
	<4F0FE087.1050204@redhat.com>
In-Reply-To: <4F0FE087.1050204@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] usb-redir: Add the posibility to filter
 out certain devices from redirecion
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/13/12 08:43, Gerd Hoffmann wrote:
> On 01/12/12 17:31, Hans de Goede wrote:
>> This patch adds the posibility to filter out certain devices from redirecion.
>> To use this pass the filter property to -device usb-redir.  The filter
>> property takes a string consisting of filter rules, the format for a rule is:
>> <class>:<vendor>:<product>:<version>:<allow>
> 
> Hmm, what is the point of having this filter in qemu?
> 
> I'd expect the other end of the network connection which talks to the
> actual usb device (i.e. the tcp standalone server or spice client) doing
> the filtering ...

Also fails checkpatch:

WARNING: line over 80 characters
#75: FILE: usb-redir.c:898:
+            qerror_report(QERR_INVALID_PARAMETER_VALUE, "filter", "a
usb device filter string");

total: 0 errors, 1 warnings, 208 lines checked

cheers,
  Gerd