From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpNN8-0008WF-6K for qemu-devel@nongnu.org; Mon, 23 Jan 2012 12:08:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpNN1-0006xi-Ql for qemu-devel@nongnu.org; Mon, 23 Jan 2012 12:07:58 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:52984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpNN1-0006xT-MZ for qemu-devel@nongnu.org; Mon, 23 Jan 2012 12:07:51 -0500 Received: by iahk25 with SMTP id k25so2895621iah.4 for ; Mon, 23 Jan 2012 09:07:50 -0800 (PST) Message-ID: <4F1D93E2.8050203@codemonkey.ws> Date: Mon, 23 Jan 2012 11:07:46 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <4F19AB66.8060901@siemens.com> <4F1D8423.2090603@codemonkey.ws> <4F1D90B7.4060202@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: Jan Kiszka , "xen-devel@lists.xensource.com" , "qemu-devel@nongnu.org" , Avi Kivity On 01/23/2012 11:05 AM, Stefano Stabellini wrote: > On Mon, 23 Jan 2012, Anthony Liguori wrote: >>> However the issue of patch #4, "do not reset videoram on resume", still >>> remains: no matter what parameter I pass to Qemu, if qemu_system_reset >>> is called on resume the videoram is going to be overwritten by 0xff. >> >> The memset(0xff) looks dubious to me. My guess is that this could be moved to >> the vgabios-cirrus which would solve your problem. >> >>> In this regard, don't you think it would be advantageous to Qemu in >>> general not to reset the videram in resume? It can be pretty large, so >>> it is a significant waste of a memset. >> >> It claims to fix a real bug. Moving the memset to vgabios would do what you >> want to do in a more robust way I think. > > I think it does fix a bug (Win2K expects RAM to be 0xff at boot, or so a > comment on qemu-xen claims) but certainly it is not supposed to run at > restore time. > I agree that moving the memset to vgabios should be a better way to fix > the problem, I'll give it a look. > Unfortutely it means finding a Win2K install CD to repro the bug, sigh. Right, it's a bit annoying, but a much nicer solution :-) Thanks, Anthony Liguori