From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43137)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RpPV3-000785-Iu
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 14:24:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RpPV1-00039Q-Dg
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 14:24:17 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:55383)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RpPV1-00039B-6B
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 14:24:15 -0500
Received: by iahk25 with SMTP id k25so3085147iah.4
	for <qemu-devel@nongnu.org>; Mon, 23 Jan 2012 11:24:14 -0800 (PST)
Message-ID: <4F1DB3D9.4080200@codemonkey.ws>
Date: Mon, 23 Jan 2012 13:24:09 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1327346110.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1327346110.git.jan.kiszka@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] Generic tick reinjection control
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Dor Laor <dlaor@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>

On 01/23/2012 01:15 PM, Jan Kiszka wrote:
> QEMU currently supports lost tick compensation for the periodic RTC
> timer. It is controlled via -rtc driftfix=slew|none. However, the next
> periodic timer with compensation qualities is approaching: KVM's
> in-kernel PIT.
>
> A previous discussion [1] showed that we need to introduce per device
> control. And we likely also want a global default. Both features require
> a generic standardized way to specify the compensation mode.
>
> So this series lays the ground for that by adding a qdev property type
> to select from four possible lost tick compensation policies (see patch
> 1 one for details). And this new property is then applied on the RTC
> device.

Looks good.  I'll take this through my tree.

Now we can just set the appropriate globals in order to enable a default rtc 
policy of slew.

Regards,

Anthony Liguori

> [1] http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85339
>
> Jan Kiszka (2):
>    qdev: Introduce lost tick policy property
>    mc146818rtc: Use lost_tick_policy property
>
>   hw/mc146818rtc.c     |   26 +++++++++++++++++------
>   hw/qdev-properties.c |   55 ++++++++++++++++++++++++++++++++++++++++++++++++++
>   hw/qdev.h            |    7 ++++++
>   qemu-common.h        |    7 ++++++
>   sysemu.h             |    1 -
>   vl.c                 |   28 ++++++++++++++++++++----
>   6 files changed, 111 insertions(+), 13 deletions(-)
>