From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpQeI-0005OR-JG for qemu-devel@nongnu.org; Mon, 23 Jan 2012 15:37:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpQeH-000485-8A for qemu-devel@nongnu.org; Mon, 23 Jan 2012 15:37:54 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:37902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpQeH-000481-3m for qemu-devel@nongnu.org; Mon, 23 Jan 2012 15:37:53 -0500 Received: by iahk25 with SMTP id k25so3189886iah.4 for ; Mon, 23 Jan 2012 12:37:52 -0800 (PST) Message-ID: <4F1DC51C.5030409@codemonkey.ws> Date: Mon, 23 Jan 2012 14:37:48 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <4F1DA926.4000709@siemens.com> <4F1DB21A.8090607@mail.berlios.de> <4F1DB2D0.9080301@siemens.com> <4F1DB432.3060804@mail.berlios.de> <4F1DBE22.609@codemonkey.ws> <4F1DC3CC.4040006@web.de> In-Reply-To: <4F1DC3CC.4040006@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH] signrom: Speed up checksum calculation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Stefan Weil , qemu-devel On 01/23/2012 02:32 PM, Jan Kiszka wrote: > On 2012-01-23 21:08, Anthony Liguori wrote: >> On 01/23/2012 01:25 PM, Stefan Weil wrote: >>> Am 23.01.2012 20:19, schrieb Jan Kiszka: >>>> On 2012-01-23 20:16, Stefan Weil wrote: >>>>> Am 23.01.2012 19:38, schrieb Jan Kiszka: >>>>> >>> [snip] >>>>> What about replacing the whole script by a python script? >>>>> That would save about 6 more forks :-) >>>> >>>> I think we have no python dependency in the build system yet - while we >>>> have for awk. That was also the original reason to go for a shell >>>> script. >>>> >>>> If the situation changed, I would not vote against python, for sure. >>>> >>>> Jan >>> >>> We do. Even configure will fail now without Python: >>> >>> if ! has $python; then >>> echo "Python not found. Use --python=/path/to/python" >>> exit 1 >>> fi >>> >>> QEMU depends on Python = Python 2 for QAPI, tracing and maybe more. >>> See scripts/*.py. >> >> I've been thinking that we could potentially rewrite a large chunk >> (all?) of configure in python too since we have such a hard dependency now. > > Sounds almost like a GSoC project. That's a good idea! > Or work for someone who did something nasty ;). Shhh, don't tell any students that :-) Regards, Anthony Liguori > At least it's no afternoon hack when done properly. > > However, I will now write signrom.py. That's much shorter. > > Jan >