From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33267)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Rpfpj-0005cM-QA
	for qemu-devel@nongnu.org; Tue, 24 Jan 2012 07:50:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Rpfpd-00073z-5j
	for qemu-devel@nongnu.org; Tue, 24 Jan 2012 07:50:43 -0500
Message-ID: <4F1EA91B.6010709@siemens.com>
Date: Tue, 24 Jan 2012 13:50:35 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <4F1EA87C.7090708@siemens.com>
In-Reply-To: <4F1EA87C.7090708@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] pcnet: Preserve link state across device
	reset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>, Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>, qemu-stable@nongnu.org

On 2012-01-24 13:47, Jan Kiszka wrote:
> A device reset does not affect the link state, only set_link does.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/pcnet.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/pcnet.c b/hw/pcnet.c
> index 306dc6e..6aa48e0 100644
> --- a/hw/pcnet.c
> +++ b/hw/pcnet.c
> @@ -688,7 +688,6 @@ static void pcnet_s_reset(PCNetState *s)
>      printf("pcnet_s_reset\n");
>  #endif
>  
> -    s->lnkst = 0x40;
>      s->rdra = 0;
>      s->tdra = 0;
>      s->rap = 0;
> @@ -1751,5 +1750,7 @@ int pcnet_common_init(DeviceState *dev, PCNetState *s, NetClientInfo *info)
>      }
>      *(uint16_t *)&s->prom[12] = cpu_to_le16(checksum);
>  
> +    s->lnkst = 0x40; /* initial link state: up */
> +
>      return 0;
>  }

Also rather trivial.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux