* [Qemu-devel] [PATCH] pcnet: Preserve link state across device reset
@ 2012-01-24 12:47 Jan Kiszka
2012-01-24 12:50 ` Jan Kiszka
2012-01-27 6:21 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Jan Kiszka @ 2012-01-24 12:47 UTC (permalink / raw)
To: qemu-devel, Anthony Liguori; +Cc: qemu-stable
A device reset does not affect the link state, only set_link does.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/pcnet.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/pcnet.c b/hw/pcnet.c
index 306dc6e..6aa48e0 100644
--- a/hw/pcnet.c
+++ b/hw/pcnet.c
@@ -688,7 +688,6 @@ static void pcnet_s_reset(PCNetState *s)
printf("pcnet_s_reset\n");
#endif
- s->lnkst = 0x40;
s->rdra = 0;
s->tdra = 0;
s->rap = 0;
@@ -1751,5 +1750,7 @@ int pcnet_common_init(DeviceState *dev, PCNetState *s, NetClientInfo *info)
}
*(uint16_t *)&s->prom[12] = cpu_to_le16(checksum);
+ s->lnkst = 0x40; /* initial link state: up */
+
return 0;
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] pcnet: Preserve link state across device reset
2012-01-24 12:47 [Qemu-devel] [PATCH] pcnet: Preserve link state across device reset Jan Kiszka
@ 2012-01-24 12:50 ` Jan Kiszka
2012-01-27 6:21 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kiszka @ 2012-01-24 12:50 UTC (permalink / raw)
To: qemu-devel, Anthony Liguori; +Cc: qemu-trivial, qemu-stable
On 2012-01-24 13:47, Jan Kiszka wrote:
> A device reset does not affect the link state, only set_link does.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/pcnet.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/hw/pcnet.c b/hw/pcnet.c
> index 306dc6e..6aa48e0 100644
> --- a/hw/pcnet.c
> +++ b/hw/pcnet.c
> @@ -688,7 +688,6 @@ static void pcnet_s_reset(PCNetState *s)
> printf("pcnet_s_reset\n");
> #endif
>
> - s->lnkst = 0x40;
> s->rdra = 0;
> s->tdra = 0;
> s->rap = 0;
> @@ -1751,5 +1750,7 @@ int pcnet_common_init(DeviceState *dev, PCNetState *s, NetClientInfo *info)
> }
> *(uint16_t *)&s->prom[12] = cpu_to_le16(checksum);
>
> + s->lnkst = 0x40; /* initial link state: up */
> +
> return 0;
> }
Also rather trivial.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] pcnet: Preserve link state across device reset
2012-01-24 12:47 [Qemu-devel] [PATCH] pcnet: Preserve link state across device reset Jan Kiszka
2012-01-24 12:50 ` Jan Kiszka
@ 2012-01-27 6:21 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-01-27 6:21 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Anthony Liguori, qemu-devel, qemu-stable
On Tue, Jan 24, 2012 at 01:47:56PM +0100, Jan Kiszka wrote:
> A device reset does not affect the link state, only set_link does.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/pcnet.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-27 6:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-24 12:47 [Qemu-devel] [PATCH] pcnet: Preserve link state across device reset Jan Kiszka
2012-01-24 12:50 ` Jan Kiszka
2012-01-27 6:21 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).