From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "seabios@seabios.org" <seabios@seabios.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"gleb@redhat.com" <gleb@redhat.com>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kernelfans@gmail.com" <kernelfans@gmail.com>,
Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>,
"kevin@koconnor.net" <kevin@koconnor.net>,
"avi@redhat.com" <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/4] uq/master: Add CPU eject handling for acpi_piix4
Date: Tue, 24 Jan 2012 13:57:52 +0100 [thread overview]
Message-ID: <4F1EAAD0.1010705@siemens.com> (raw)
In-Reply-To: <4F1EA99C.702@suse.de>
On 2012-01-24 13:52, Andreas Färber wrote:
> Am 24.01.2012 11:28, schrieb Jan Kiszka:
>> On 2012-01-24 11:10, Vasilis Liaskovitis wrote:
>>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
>>> index ac251c6..6d61567 100644
>>> --- a/hw/pc_piix.c
>>> +++ b/hw/pc_piix.c
>>> @@ -380,6 +380,14 @@ static QEMUMachine pc_machine_v1_1 = {
>>> .desc = "Standard PC",
>>> .init = pc_init_pci,
>>> .max_cpus = 255,
>>> + .compat_props = (GlobalProperty[]) {
>>> + {
>>> + .driver = "PIIX4_PM",
>>> + .property = "cpu_acpi_eject",
>>> + .value = stringify(1),
>>
>> Such things are usually handled the other way around: define
>> no_cpu_acpi_eject and set it in all legacy machines.
>
> Either way reminds me that qdev bool support never got merged. I'll dig
> it out and rebase.
Perfect! I really hate to model bool via bit.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-01-24 12:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 10:10 [Qemu-devel] [PATCH v2 0/4] acpi_piix4: Add CPU eject infrastructure for pc-1.1 Vasilis Liaskovitis
2012-01-24 10:10 ` [Qemu-devel] [PATCH v2 1/4][SeaBios] Add bitmap for CPU EJ0 callback Vasilis Liaskovitis
2012-01-24 10:10 ` [Qemu-devel] [PATCH 2/4] uq/master: Add machine model pc-1.1 Vasilis Liaskovitis
2012-01-24 10:10 ` [Qemu-devel] [PATCH v2 3/4] uq/master: Add CPU eject handling for acpi_piix4 Vasilis Liaskovitis
2012-01-24 10:28 ` Jan Kiszka
2012-01-24 12:52 ` Andreas Färber
2012-01-24 12:57 ` Jan Kiszka [this message]
2012-01-24 14:56 ` Vasilis Liaskovitis
2012-01-26 10:46 ` Avi Kivity
2012-01-30 10:14 ` Vasilis Liaskovitis
2012-01-24 10:10 ` [Qemu-devel] [PATCH 4/4] uq/master: Add acpi cpu interface documentation Vasilis Liaskovitis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1EAAD0.1010705@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=afaerber@suse.de \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kernelfans@gmail.com \
--cc=kevin@koconnor.net \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
--cc=vasilis.liaskovitis@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).