From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpfxC-0003jI-0m for qemu-devel@nongnu.org; Tue, 24 Jan 2012 07:58:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rpfx1-00084j-4o for qemu-devel@nongnu.org; Tue, 24 Jan 2012 07:58:25 -0500 Received: from david.siemens.de ([192.35.17.14]:20548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rpfx0-000843-QI for qemu-devel@nongnu.org; Tue, 24 Jan 2012 07:58:15 -0500 Message-ID: <4F1EAAD0.1010705@siemens.com> Date: Tue, 24 Jan 2012 13:57:52 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1327399808-31081-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1327399808-31081-4-git-send-email-vasilis.liaskovitis@profitbricks.com> <4F1E87D9.6000008@siemens.com> <4F1EA99C.702@suse.de> In-Reply-To: <4F1EA99C.702@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/4] uq/master: Add CPU eject handling for acpi_piix4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: "seabios@seabios.org" , "kvm@vger.kernel.org" , "gleb@redhat.com" , "mtosatti@redhat.com" , "qemu-devel@nongnu.org" , "kernelfans@gmail.com" , Vasilis Liaskovitis , "kevin@koconnor.net" , "avi@redhat.com" On 2012-01-24 13:52, Andreas F=E4rber wrote: > Am 24.01.2012 11:28, schrieb Jan Kiszka: >> On 2012-01-24 11:10, Vasilis Liaskovitis wrote: >>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c >>> index ac251c6..6d61567 100644 >>> --- a/hw/pc_piix.c >>> +++ b/hw/pc_piix.c >>> @@ -380,6 +380,14 @@ static QEMUMachine pc_machine_v1_1 =3D { >>> .desc =3D "Standard PC", >>> .init =3D pc_init_pci, >>> .max_cpus =3D 255, >>> + .compat_props =3D (GlobalProperty[]) { >>> + { >>> + .driver =3D "PIIX4_PM", >>> + .property =3D "cpu_acpi_eject", >>> + .value =3D stringify(1), >> >> Such things are usually handled the other way around: define >> no_cpu_acpi_eject and set it in all legacy machines. >=20 > Either way reminds me that qdev bool support never got merged. I'll dig > it out and rebase. Perfect! I really hate to model bool via bit. Jan --=20 Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux