qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v8 18/18] kvm: Activate in-kernel irqchip support
Date: Tue, 24 Jan 2012 09:34:58 -0600	[thread overview]
Message-ID: <4F1ECFA2.4000304@us.ibm.com> (raw)
In-Reply-To: <4F1EBC8D.5000403@redhat.com>

On 01/24/2012 08:13 AM, Avi Kivity wrote:
> On 01/24/2012 04:10 PM, Jan Kiszka wrote:
>> On 2012-01-24 15:05, Avi Kivity wrote:
>>> On 01/19/2012 08:54 PM, Jan Kiszka wrote:
>>>> Nope, see kvm_irqchip_create, patch 13. You can also check by browsing
>>>> the qtree (different device model names).
>>>
>>> That was my biggest objection to the previous iterations.  Later
>>> versions changed to use an attribute (selecting the backend).  What
>>> happened now?
>>
>> The other approach was rejected.
>
> Sigh.  We'll regret this.

No we won't.  The other approach was creating a mini-qdev as a mechanism to hide 
the fact that we have two different implementations of the same device.

We need to expose this information to the user in some fashion.  The type is the 
natural way to do it.

Regards,

Anthony Liguori

>
>> Moreover, see http://thread.gmane.org/gmane.comp.emulators.qemu/129659,
>> QOM will allow addressing with identical paths.
>
> At least that.

  reply	other threads:[~2012-01-24 15:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19 11:24 [Qemu-devel] [PATCH v8 00/18] uq/master: Introduce basic irqchip support Jan Kiszka
2012-01-19 11:24 ` [Qemu-devel] [PATCH v8 01/18] msi: Generalize msix_supported to msi_supported Jan Kiszka
2012-01-19 11:24 ` [Qemu-devel] [PATCH v8 02/18] kvm: Move kvmclock into hw/kvm folder Jan Kiszka
2012-01-19 11:24 ` [Qemu-devel] [PATCH v8 03/18] apic: Stop timer on reset Jan Kiszka
2012-01-19 11:24 ` [Qemu-devel] [PATCH v8 04/18] apic: Inject external NMI events via LINT1 Jan Kiszka
2012-01-19 11:24 ` [Qemu-devel] [PATCH v8 05/18] apic: Introduce apic_report_irq_delivered Jan Kiszka
2012-01-19 11:24 ` [Qemu-devel] [PATCH v8 06/18] apic: Factor out base class for KVM reuse Jan Kiszka
2012-01-19 11:24 ` [Qemu-devel] [PATCH v8 07/18] apic: Open-code timer save/restore Jan Kiszka
2012-01-19 11:25 ` [Qemu-devel] [PATCH v8 08/18] i8259: Completely privatize PicState Jan Kiszka
2012-01-19 11:25 ` [Qemu-devel] [PATCH v8 09/18] i8259: Factor out base class for KVM reuse Jan Kiszka
2012-01-19 11:25 ` [Qemu-devel] [PATCH v8 10/18] ioapic: Drop post-load irr initialization Jan Kiszka
2012-01-19 11:25 ` [Qemu-devel] [PATCH v8 11/18] ioapic: Factor out base class for KVM reuse Jan Kiszka
2012-01-19 11:25 ` [Qemu-devel] [PATCH v8 12/18] memory: Introduce memory_region_init_reservation Jan Kiszka
2012-01-19 11:25 ` [Qemu-devel] [PATCH v8 13/18] kvm: Introduce core services for in-kernel irqchip support Jan Kiszka
2012-01-19 11:25 ` [Qemu-devel] [PATCH v8 14/18] kvm: x86: Establish IRQ0 override control Jan Kiszka
2012-01-19 11:25 ` [Qemu-devel] [PATCH v8 15/18] kvm: x86: Add user space part for in-kernel APIC Jan Kiszka
2012-01-19 11:25 ` [Qemu-devel] [PATCH v8 16/18] kvm: x86: Add user space part for in-kernel i8259 Jan Kiszka
2012-01-19 11:25 ` [Qemu-devel] [PATCH v8 17/18] kvm: x86: Add user space part for in-kernel IOAPIC Jan Kiszka
2012-01-19 11:25 ` [Qemu-devel] [PATCH v8 18/18] kvm: Activate in-kernel irqchip support Jan Kiszka
2012-01-19 18:08   ` Marcelo Tosatti
2012-01-19 18:54     ` Jan Kiszka
2012-01-24 14:05       ` Avi Kivity
2012-01-24 14:10         ` Jan Kiszka
2012-01-24 14:13           ` Avi Kivity
2012-01-24 15:34             ` Anthony Liguori [this message]
2012-01-24 15:33         ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1ECFA2.4000304@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).