From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpiPY-0003Qj-JJ for qemu-devel@nongnu.org; Tue, 24 Jan 2012 10:35:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpiPU-0001yT-09 for qemu-devel@nongnu.org; Tue, 24 Jan 2012 10:35:52 -0500 Received: from e38.co.us.ibm.com ([32.97.110.159]:37920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpiPT-0001yL-Ln for qemu-devel@nongnu.org; Tue, 24 Jan 2012 10:35:47 -0500 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Jan 2012 08:35:45 -0700 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id B6E821FF004C for ; Tue, 24 Jan 2012 08:35:20 -0700 (MST) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0OFZ526084228 for ; Tue, 24 Jan 2012 08:35:08 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0OFZ4vU027246 for ; Tue, 24 Jan 2012 08:35:04 -0700 Message-ID: <4F1ECFA2.4000304@us.ibm.com> Date: Tue, 24 Jan 2012 09:34:58 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <6a48ffaaa732b2142c1b5030178f2d4a0fa499fe.1326972302.git.jan.kiszka@siemens.com> <20120119180851.GA19099@amt.cnet> <4F1866E0.7010900@web.de> <4F1EBAAF.8040808@redhat.com> <4F1EBBD7.2050007@siemens.com> <4F1EBC8D.5000403@redhat.com> In-Reply-To: <4F1EBC8D.5000403@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 18/18] kvm: Activate in-kernel irqchip support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Jan Kiszka , Marcelo Tosatti , qemu-devel , Blue Swirl On 01/24/2012 08:13 AM, Avi Kivity wrote: > On 01/24/2012 04:10 PM, Jan Kiszka wrote: >> On 2012-01-24 15:05, Avi Kivity wrote: >>> On 01/19/2012 08:54 PM, Jan Kiszka wrote: >>>> Nope, see kvm_irqchip_create, patch 13. You can also check by browsing >>>> the qtree (different device model names). >>> >>> That was my biggest objection to the previous iterations. Later >>> versions changed to use an attribute (selecting the backend). What >>> happened now? >> >> The other approach was rejected. > > Sigh. We'll regret this. No we won't. The other approach was creating a mini-qdev as a mechanism to hide the fact that we have two different implementations of the same device. We need to expose this information to the user in some fashion. The type is the natural way to do it. Regards, Anthony Liguori > >> Moreover, see http://thread.gmane.org/gmane.comp.emulators.qemu/129659, >> QOM will allow addressing with identical paths. > > At least that.