From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47824)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1RpmZE-0001Za-Id
	for qemu-devel@nongnu.org; Tue, 24 Jan 2012 15:02:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1RpmZA-0008N5-5V
	for qemu-devel@nongnu.org; Tue, 24 Jan 2012 15:02:08 -0500
Message-ID: <4F1F0E2D.2020706@web.de>
Date: Tue, 24 Jan 2012 21:01:49 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <1327433600-7403-1-git-send-email-aliguori@us.ibm.com>
	<1327433600-7403-28-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1327433600-7403-28-git-send-email-aliguori@us.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig3E5ED38255BBDA1FA2F68CC6"
Subject: Re: [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to
	QEMU Object Model
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, =?ISO-8859-15?Q?Andreas_F=E4rbe?= =?ISO-8859-15?Q?r?= <andreas.faerber@web.de>, qemu-ppc@nongnu.org, Paul Brook <paul@codesourcery.com>, Aurelien Jarno <aurelien@aurel32.net>, Gerd Hoffmann <kraxel@redhat.com>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig3E5ED38255BBDA1FA2F68CC6
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

On 2012-01-24 20:33, Anthony Liguori wrote:
> This converts three devices because apic and ioapic are subclasses of s=
ysbus.
> Converting subclasses independently of their base class is prohibitivel=
y hard.

Hmm, I think that's more than three... Can you split up? At least per
target or per board/machine.

Also, I see a lot of programmatic initialization and a lot of repeating
patterns (specifically regarding trivial class initialization) - there
is no better alternative?

Jan


--------------enig3E5ED38255BBDA1FA2F68CC6
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk8fDi0ACgkQitSsb3rl5xSh5wCfcLRra9rU6iUGXMIa0GcB+O5g
85gAn3zVArbze2mZ4g/8GnAHJLqmnE9C
=fvFO
-----END PGP SIGNATURE-----

--------------enig3E5ED38255BBDA1FA2F68CC6--