From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rq1Pk-00040k-TY for qemu-devel@nongnu.org; Wed, 25 Jan 2012 06:53:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rq1Pf-0005gC-4n for qemu-devel@nongnu.org; Wed, 25 Jan 2012 06:53:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rq1Pe-0005g6-I7 for qemu-devel@nongnu.org; Wed, 25 Jan 2012 06:53:15 -0500 Message-ID: <4F1FED1C.3000705@redhat.com> Date: Wed, 25 Jan 2012 13:53:00 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1327490809-21393-1-git-send-email-owasserm@redhat.com> In-Reply-To: <1327490809-21393-1-git-send-email-owasserm@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 00/11] XBRLE delta for live migration of large memory app List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, Petter Svard , Benoit Hudzia , Aidan Shribman On 01/25/2012 01:26 PM, Orit Wasserman wrote: > The run length is encoded using ULEB128 (http://en.wikipedia.org/wiki/LEB128) > > page = zrun > | zrun nzrun > | zrun nzrun page > > zrun = length > > nzrun = length byte... > > length = uleb128 encoded integer > We can improve this by a further 2 bytes per page by not encoding the trailing zero run: page = zrun nzrun | zrun nzrun page so, a page containing { 10*0, 7, 4085*0 } would be encoded as 0x10 0x01 0x07 without the trailing 4085 zrun. This works because you no longer send unchanged pages. -- error compiling committee.c: too many arguments to function