From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rq1XC-00077B-EY for qemu-devel@nongnu.org; Wed, 25 Jan 2012 07:01:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rq1XA-0006nC-4m for qemu-devel@nongnu.org; Wed, 25 Jan 2012 07:01:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rq1X9-0006n1-SQ for qemu-devel@nongnu.org; Wed, 25 Jan 2012 07:01:00 -0500 Message-ID: <4F1FEEF1.6060801@redhat.com> Date: Wed, 25 Jan 2012 14:00:49 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1326974181-32511-5-git-send-email-stefano.stabellini@eu.citrix.com> <1326975896.17599.81.camel@zakaz.uk.xensource.com> <1326981859.17599.87.camel@zakaz.uk.xensource.com> <4F1FEB59.8060102@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: "jan.kiszka@siemens.com" , "xen-devel@lists.xensource.com" , Ian Campbell , "qemu-devel@nongnu.org" On 01/25/2012 01:55 PM, Stefano Stabellini wrote: > > > > Match on just the MemoryRegion (and match on the object itself, not the > > name; see xen_register_framebuffer()). > > I agree that would be ideal, but how can that work across save/restore? > Unless we introduce some other kind of identifier for MemoryRegion, the > best we have is the name right now, correct? Right, you can't put the pointer in save/restore, the name is the only option (and that's what qemu uses in its native save format). I thought you were talking about internal matching, like in a previous version of the patch/discussion. -- error compiling committee.c: too many arguments to function