From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47531)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rq2uO-0005z5-6s
	for qemu-devel@nongnu.org; Wed, 25 Jan 2012 08:29:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rq2uH-0007Br-26
	for qemu-devel@nongnu.org; Wed, 25 Jan 2012 08:29:04 -0500
Received: from mail-pz0-f45.google.com ([209.85.210.45]:44875)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rq2uG-0007BJ-Sy
	for qemu-devel@nongnu.org; Wed, 25 Jan 2012 08:28:57 -0500
Received: by dajr28 with SMTP id r28so2510996daj.4
	for <qemu-devel@nongnu.org>; Wed, 25 Jan 2012 05:28:55 -0800 (PST)
Message-ID: <4F200392.4020400@codemonkey.ws>
Date: Wed, 25 Jan 2012 07:28:50 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1327433600-7403-1-git-send-email-aliguori@us.ibm.com>	<1327433600-7403-4-git-send-email-aliguori@us.ibm.com>
	<20120125124210.GB22203@redhat.com>
In-Reply-To: <20120125124210.GB22203@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/28] pci: call reset unconditionally
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/25/2012 06:42 AM, Michael S. Tsirkin wrote:
> On Tue, Jan 24, 2012 at 01:32:55PM -0600, Anthony Liguori wrote:
>> Because now all PCI devices are converted to qdev.
>>
>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>
> Finally!

Yeah, I hope there's more cleanup that can come out of this.

Regards,

Anthony Liguori

>
>> ---
>>   hw/pci.c |    7 ++-----
>>   1 files changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/hw/pci.c b/hw/pci.c
>> index 54400ac..ab3b53d 100644
>> --- a/hw/pci.c
>> +++ b/hw/pci.c
>> @@ -159,11 +159,8 @@ void pci_device_deassert_intx(PCIDevice *dev)
>>   void pci_device_reset(PCIDevice *dev)
>>   {
>>       int r;
>> -    /* TODO: call the below unconditionally once all pci devices
>> -     * are qdevified */
>> -    if (dev->qdev.info) {
>> -        qdev_reset_all(&dev->qdev);
>> -    }
>> +
>> +    qdev_reset_all(&dev->qdev);
>>
>>       dev->irq_state = 0;
>>       pci_update_irq_status(dev);
>> --
>> 1.7.4.1
>