From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 6/9] hw/vexpress.c: Factor out daughterboard-specific initialization
Date: Wed, 25 Jan 2012 19:04:31 +0100 [thread overview]
Message-ID: <4F20442F.20701@suse.de> (raw)
In-Reply-To: <1327408760-3666-7-git-send-email-peter.maydell@linaro.org>
Am 24.01.2012 13:39, schrieb Peter Maydell:
> Factor out daughterboard specifics into a data structure and
> daughterboard initialization function, in preparation for adding
> vexpress-a15 support.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/vexpress.c | 118 ++++++++++++++++++++++++++++++++++++++++-----------------
> 1 files changed, 83 insertions(+), 35 deletions(-)
>
> diff --git a/hw/vexpress.c b/hw/vexpress.c
> index 99a9690..9033b50 100644
> --- a/hw/vexpress.c
> +++ b/hw/vexpress.c
> +struct VEDBoardInfo {
> + const target_phys_addr_t *motherboard_map;
> + const target_phys_addr_t loader_start;
const for a value type in a struct looks fishy...is it intentional and
valid C99?
Otherwise looks okay.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-01-25 18:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 12:39 [Qemu-devel] [PATCH v2 0/9] Add support for Cortex-A15 and vexpress-a15 Peter Maydell
2012-01-24 12:39 ` [Qemu-devel] [PATCH v2 1/9] Add dummy implementation of generic timer cp15 registers Peter Maydell
2012-01-25 12:37 ` Andreas Färber
2012-01-25 13:01 ` Peter Maydell
2012-01-24 12:39 ` [Qemu-devel] [PATCH v2 2/9] Add Cortex-A15 CPU definition Peter Maydell
2012-01-25 12:31 ` Andreas Färber
2012-01-24 12:39 ` [Qemu-devel] [PATCH v2 3/9] hw/a15mpcore.c: Add Cortex-A15 private peripheral model Peter Maydell
2012-01-25 16:08 ` Andreas Färber
2012-01-24 12:39 ` [Qemu-devel] [PATCH v2 4/9] hw/vexpress.c: Make motherboard peripheral memory map table-driven Peter Maydell
2012-01-25 16:59 ` Andreas Färber
2012-01-24 12:39 ` [Qemu-devel] [PATCH v2 5/9] hw/vexpress.c: Move secondary CPU boot code to SRAM Peter Maydell
2012-01-24 12:39 ` [Qemu-devel] [PATCH v2 6/9] hw/vexpress.c: Factor out daughterboard-specific initialization Peter Maydell
2012-01-25 18:04 ` Andreas Färber [this message]
2012-01-25 19:53 ` Peter Maydell
2012-01-24 12:39 ` [Qemu-devel] [PATCH v2 7/9] hw/vexpress.c: Instantiate the motherboard CLCD Peter Maydell
2012-01-25 18:28 ` Andreas Färber
2012-02-10 2:51 ` Paul Brook
2012-02-15 13:36 ` Peter Maydell
2012-01-24 12:39 ` [Qemu-devel] [PATCH v2 8/9] arm_boot: Pass base address of GIC CPU interface, not whole GIC Peter Maydell
2012-01-24 12:39 ` [Qemu-devel] [PATCH v2 9/9] hw/vexpress.c: Add vexpress-a15 machine Peter Maydell
2012-01-25 18:15 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F20442F.20701@suse.de \
--to=afaerber@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).