qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Erik Rull <erik.rull@rdsoftware.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] git bisect results
Date: Wed, 25 Jan 2012 22:13:52 +0100	[thread overview]
Message-ID: <4F207090.9060806@rdsoftware.de> (raw)
In-Reply-To: <4F200F60.3050206@siemens.com>

Jan Kiszka wrote:
> On 2012-01-25 12:48, erik.rull@rdsoftware.de wrote:
>> Hi Jan,
>
> You should CC me then... :)

I will do that for upcoming emails.

>>
>> This little change fixes my problem with the usb-tablet update rate.
>>
>> Can you please verify if this has some side effects?
>
> Surely as it disables in general valid code, namely the auto-grabbing
> feature. You should notice the difference.
>
>>
>> If not, can you post a real patch?
>> I don't know how to handle the whole patching and committing stuff exactly.
>
> We need to understand the problem first anyway, and as I cannot
> reproduce it, I will need you help:
>
> Can you instrument the code, e.g. with printf, to find out which of the
> disabled branches is taken when, specifically how often? Can you also
> check if values like max_x/max_y or the ev->motion content make sense
> for your setup?
>
> Thanks,
> Jan
>

Yes, I will add some counters and dump them in discrete timeslots to see 
what's the difference between the fullscreen and the windowed mode.

Maybe the removed code parts do not affect my main application where the 
window is resized to fullscreen. But for maintenance it is definitively 
windowed where I haven't had any problems with the grabbing / releasing up 
to now.

Best regards,

Erik

  reply	other threads:[~2012-01-25 21:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-25 11:48 [Qemu-devel] git bisect results erik.rull
2012-01-25 14:19 ` Jan Kiszka
2012-01-25 21:13   ` Erik Rull [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-01-30 11:34 Erik Rull
2012-01-30 11:52 ` Jan Kiszka
2012-01-30 13:17   ` Erik Rull
2012-01-30 13:48     ` Jan Kiszka
2012-01-30 14:17       ` Erik Rull
2012-01-30 14:48         ` Jan Kiszka
2012-01-31  8:31           ` Erik Rull
2012-01-26 13:10 Erik Rull
2012-01-26 16:24 ` Jan Kiszka
2012-01-27 22:52 ` Jan Kiszka
2012-01-28 11:55   ` Jan Kiszka
2012-01-28 12:39     ` Erik Rull
2012-01-28 12:43       ` Jan Kiszka
2012-01-28 13:01         ` Erik Rull
2012-01-28 14:52           ` Jan Kiszka
2012-01-23  8:57 [Qemu-devel] bad USB tablet update rate on qemu-1.0 erik.rull
2012-01-24 17:24 ` [Qemu-devel] git bisect results (was: Re: bad USB tablet update rate on qemu-1.0) Erik Rull
2012-01-24 18:19   ` [Qemu-devel] git bisect results Jan Kiszka
2012-01-24 18:55     ` Erik Rull
2012-01-24 20:15       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F207090.9060806@rdsoftware.de \
    --to=erik.rull@rdsoftware.de \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).