From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqBiJ-0006PK-Jp for qemu-devel@nongnu.org; Wed, 25 Jan 2012 17:53:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqBiH-0007O9-TK for qemu-devel@nongnu.org; Wed, 25 Jan 2012 17:53:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqBiH-0007Nx-HM for qemu-devel@nongnu.org; Wed, 25 Jan 2012 17:53:09 -0500 Message-ID: <4F2087D2.4050203@redhat.com> Date: Wed, 25 Jan 2012 15:53:06 -0700 From: Eric Blake MIME-Version: 1.0 References: <1327531142-31182-1-git-send-email-ronniesahlberg@gmail.com> <1327531142-31182-2-git-send-email-ronniesahlberg@gmail.com> In-Reply-To: <1327531142-31182-2-git-send-email-ronniesahlberg@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigAD3A6DA97447A1AE51C14C0F" Subject: Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ronnie Sahlberg Cc: kwolf@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAD3A6DA97447A1AE51C14C0F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/25/2012 03:39 PM, Ronnie Sahlberg wrote: > This patch adds configuration variables for iSCSI to set > initiator-name to use when logging in to the target, > which type of header-digest to negotiate with the target > and username and password for CHAP authentication. >=20 > This allows specifying a initiator-name either from the command line > -iscsi initiator-name=3Diqn.2004-01.com.example:test > or from a configuration file included with -readconfig > [iscsi] > initiator-name =3D iqn.2004-01.com.example:test > header-digest =3D CRC32C|CRC32C-NONE|NONE-CRC32C|NONE > user =3D CHAP username > password =3D CHAP password >=20 > If you use several different targets, you can also configure this on a = per > target basis by using a group name: > [iscsi "iqn.target.name"] > ... >=20 > The configuration file can be read using -readconfig. > Example : > qemu-system-i386 -drive file=3Discsi://127.0.0.1/iqn.ronnie.test/1 > -readconfig iscsi.conf >=20 > Signed-off-by: Ronnie Sahlberg > --- > block/iscsi.c | 139 +++++++++++++++++++++++++++++++++++++++++++++++= ++++---- > qemu-config.c | 27 +++++++++++ > qemu-doc.texi | 54 +++++++++++++++++++++- > qemu-options.hx | 16 +++++-- > vl.c | 8 +++ > 5 files changed, 229 insertions(+), 15 deletions(-) I don't know the qemu code base well enough to give a full ack, but I can at least state that you addressed my concerns from v1. Thanks! > +++ b/qemu-doc.texi > @@ -730,6 +730,57 @@ export LIBISCSI_CHAP_PASSWORD=3D > + > + > +Howto use a configuration file to set iSCSI configuration options: s/Howto/How to/ > +@example > +cat >iscsi.conf < +[iscsi] > + user =3D "me" > + password =3D "my password" > + initiator-name =3D "iqn.qemu.test:my-initiator" > + header-digest =3D "CRC32C" > +EOF > + > +qemu-system-i386 -drive file=3Discsi://127.0.0.1/iqn.qemu.test/1 \ > + -readconfig iscsi.conf > +@end example > + > + > Howto set up a simple iSCSI target on loopback and accessing it via QE= MU: then again, you were copying and pasting. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigAD3A6DA97447A1AE51C14C0F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPIIfSAAoJEKeha0olJ0NqWuEH/RWhh8joXoYFX2aDhtK1hSc9 Zv5EA0cJwB3erlR4CrxmADWJ59FJ+PDl7tXIKkJwcb8/zrb6D5PPVy2idllhokgo AUYSTg/TjypeHWndpRWpOeyGt3hT40kbvNr9d0NrMlEat+ZFq7OKQ9tJiG75q6k5 K+hhzJ1rGdfP1wwyG/LDEB2ZBq2GHpCsRBRRh23jt09TE8h5ClF+9cU/PEMwuNhG A3205TvdKphx4INViakAwdzEjhSKBiNPBeNZPOCt9zqg7qBqzbjB4gpN0ZnrEgJw IrbCGEwQdvPTt/vv0LaFfhSQYj/z4FS3K4VOLzW7I6gXT6nH+NsQvCu+Hx6IaVI= =i1jq -----END PGP SIGNATURE----- --------------enigAD3A6DA97447A1AE51C14C0F--