From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] scsi: Guard against buflen exceeding req->cmd.xfer in scsi_disk_emulate_command
Date: Thu, 26 Jan 2012 11:41:38 +0100 [thread overview]
Message-ID: <4F212DE2.2080202@redhat.com> (raw)
In-Reply-To: <4F2105B1.7070706@redhat.com>
Am 26.01.2012 08:50, schrieb Paolo Bonzini:
> On 01/24/2012 06:19 PM, Thomas Higdon wrote:
>> I agree that it's better to get this into a more general place. However,
>> I wasn't willing to pull the MIN statement up into scsi_send_command
>> because I don't understand the interplay between 'len' in that function
>> and r->iov.iov_len. I couldn't see that there was a general relationship
>> between these two variables that applied to both read/write commands and
>> other commands.
>
> That's good enough, and it should fix also the bugs with GET
> CONFIGURATION that Artyom reported. Two birds with a stone!
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Kevin, shall I take this patch in the virtio-scsi series? I'll have to
> resubmit anyway due to the QOM changes.
I have picked it up for the block branch. If it conflicts with your
changes, you can just rebase on top of that.
Kevin
next prev parent reply other threads:[~2012-01-26 10:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 17:15 [Qemu-devel] [PATCH] scsi: restrict buffer length to req->cmd.xfer for responses to INQUIRY commands Thomas Higdon
2012-01-23 17:47 ` Paolo Bonzini
2012-01-23 18:14 ` Thomas Higdon
2012-01-24 8:21 ` Paolo Bonzini
2012-01-24 13:53 ` Kevin Wolf
2012-01-24 17:19 ` [Qemu-devel] [PATCH] scsi: Guard against buflen exceeding req->cmd.xfer in scsi_disk_emulate_command Thomas Higdon
2012-01-26 7:50 ` Paolo Bonzini
2012-01-26 10:41 ` Kevin Wolf [this message]
2012-01-26 10:53 ` Paolo Bonzini
2012-01-27 5:59 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-01-27 8:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F212DE2.2080202@redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).