From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqNYq-0003H4-KQ for qemu-devel@nongnu.org; Thu, 26 Jan 2012 06:32:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqNYl-0007tK-1T for qemu-devel@nongnu.org; Thu, 26 Jan 2012 06:32:12 -0500 Received: from mel.act-europe.fr ([194.98.77.210]:37837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqNYk-0007r9-KE for qemu-devel@nongnu.org; Thu, 26 Jan 2012 06:32:07 -0500 Message-ID: <4F213999.4060509@adacore.com> Date: Thu, 26 Jan 2012 12:31:37 +0100 From: Fabien Chouteau MIME-Version: 1.0 References: <1327570411-20432-1-git-send-email-avi@redhat.com> In-Reply-To: <1327570411-20432-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: fix return value on unassigned reads List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Blue Swirl , qemu-devel@nongnu.org, atar4qemu@gmail.com On 26/01/2012 10:33, Avi Kivity wrote: > The memory API returns -1 on unassigned reads, different from the original > in exec.c, which returned zero. Isn't this return value platform specific? > This breaks grlib_uart; apparently some users depend on it. > > Fix by returning zero; however if reading from the uart is legal, then > it should be modified to accept reads. > That's right, grlib_uart depends on it because I took the easy (lazy?) way. I will send a patch to handle reads to UART's registers. -- Fabien Chouteau