From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50255 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqVBv-0006Rp-Rk for qemu-devel@nongnu.org; Thu, 26 Jan 2012 14:41:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqVBn-0005qj-Br for qemu-devel@nongnu.org; Thu, 26 Jan 2012 14:40:57 -0500 Received: from e39.co.us.ibm.com ([32.97.110.160]:56191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqVBn-0005qV-4v for qemu-devel@nongnu.org; Thu, 26 Jan 2012 14:40:55 -0500 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Jan 2012 12:40:53 -0700 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 281BE3E4004C for ; Thu, 26 Jan 2012 12:40:51 -0700 (MST) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0QJencM107148 for ; Thu, 26 Jan 2012 12:40:50 -0700 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0QJemnJ010587 for ; Thu, 26 Jan 2012 12:40:48 -0700 Message-ID: <4F21AC40.8040207@us.ibm.com> Date: Thu, 26 Jan 2012 13:40:48 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1327604460-31142-1-git-send-email-aliguori@us.ibm.com> <1327604460-31142-2-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1327604460-31142-2-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , Jan Kiszka , qemu-devel@nongnu.org, Markus Armbruster , Avi Kivity , Paolo Bonzini On 01/26/2012 01:00 PM, Anthony Liguori wrote: > A long time ago, there was a grand plan to merge q35 chipset support. The start > of that series was a refactoring of pc.c which split a bunch of the "common" > functionality into a separate file that could be shared by the two. > > But q35 never got merged and the refactoring, in retrospect, just made things > worse. Making things proper objects and using composition is the right way > to share common devices. > > By pulling these files back together, we can start to fix some of this mess. > > Signed-off-by: Anthony Liguori BTW, the whole series is also available at: https://github.com/aliguori/qemu/tree/qom-rebase.10 If you just want to skip ahead to the good stuff, look at: https://github.com/aliguori/qemu/blob/qom-rebase.10/hw/piix_pci.c#L384 Compared to: http://git.qemu.org/?p=qemu.git;a=blob;f=hw/piix_pci.c;h=3652522e58f0bbed35d687013af9978bdb4901f7;hb=HEAD#l252 Regards, Anthony Liguori