From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqZGA-0003YW-0S for qemu-devel@nongnu.org; Thu, 26 Jan 2012 19:01:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqZG9-0004XQ-3A for qemu-devel@nongnu.org; Thu, 26 Jan 2012 19:01:42 -0500 Received: from e33.co.us.ibm.com ([32.97.110.151]:53062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqZG8-0004XG-Jz for qemu-devel@nongnu.org; Thu, 26 Jan 2012 19:01:41 -0500 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Jan 2012 17:01:38 -0700 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id CF4273E40036 for ; Thu, 26 Jan 2012 17:01:31 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0R01QB3060376 for ; Thu, 26 Jan 2012 17:01:29 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0R01Mes024786 for ; Thu, 26 Jan 2012 17:01:23 -0700 Message-ID: <4F21E949.6050103@linux.vnet.ibm.com> Date: Thu, 26 Jan 2012 18:01:13 -0600 From: Michael Roth MIME-Version: 1.0 References: <20120126144632.GM21211@redhat.com> <4F216EAB.2000707@redhat.com> In-Reply-To: <4F216EAB.2000707@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: libvir-list@redhat.com, Michal Privoznik , QEMU Developers On 01/26/2012 09:18 AM, Eric Blake wrote: > [adding qemu-devel] > > On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: >>> One thing, that you'll probably notice is this >>> 'set-support-level' command. Basically, it tells GA what qemu version >>> is it running on. Ideally, this should be done as soon as >>> GA starts up. However, that cannot be determined from outside >>> world as GA doesn't emit any events yet. >>> Ideally^2 this command should be left out as it should be qemu >>> who tells its own agent this kind of information. >>> Anyway, I was going to call this command in qemuProcess{Startup, >>> Reconnect,Attach}, but it won't work. We need to un-pause guest CPUs >>> so guest can boot and start GA, but that implies returning from qemuProcess*. >>> >>> So I am setting this just before 'guest-suspend' command, as >>> there is one more thing about GA. It is unable to remember anything >>> upon its restart (GA process). Which has BTW show flaw >>> in our current code with FS freeze& thaw. If we freeze guest >>> FS, and somebody restart GA, the simple FS Thaw will not succeed as >>> GA thinks FS are not frozen. But that's a different cup of tea. We could drop the state tracking (guest-fsfreeze-status) and issue the freeze/thaw unconditionally. Talked with Anthony and going stateless in general seems to solve a lot of nastiness that might pop up with the current implementation. I'll send some patches out soon for fsfreeze, guest-file* may end up getting similar treatment in the not-too-distant-future.