From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60758)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RqmRK-0007zH-9e
	for qemu-devel@nongnu.org; Fri, 27 Jan 2012 09:06:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RqmRJ-0001H0-4O
	for qemu-devel@nongnu.org; Fri, 27 Jan 2012 09:06:06 -0500
Received: from cantor2.suse.de ([195.135.220.15]:35369 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RqmRI-0001Gn-W0
	for qemu-devel@nongnu.org; Fri, 27 Jan 2012 09:06:05 -0500
Message-ID: <4F22AECA.50800@suse.de>
Date: Fri, 27 Jan 2012 15:03:54 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1327604460-31142-1-git-send-email-aliguori@us.ibm.com>	<1327604460-31142-2-git-send-email-aliguori@us.ibm.com>
	<4F226562.6010300@siemens.com> <4F22A18C.4090608@codemonkey.ws>
In-Reply-To: <4F22A18C.4090608@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, =?ISO-8859-15?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>, Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

Am 27.01.2012 14:07, schrieb Anthony Liguori:
> [...] My guess is that a SuperIO
> chip could be an ISADevice and that we could simply make the PIIX3 has-=
a
> SuperIO.  Then the ISAPC would have a trivial ISA chipset that has-a
> SuperIO.

That sounds pretty much like our construction site for PReP...
Would you say that the SuperIO is-a ISADevice and has-a ISADevice or
would you want to remodel all ISADevices associated with a Super I/O
chipset as private devices to mess with their internals without the
whole enable/disable, etc. ugliness we ran into?

I somewhat doubt that we can find a generic "SuperIO" base class btw.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg