From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqn1z-0003rQ-N0 for qemu-devel@nongnu.org; Fri, 27 Jan 2012 09:44:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rqn1v-0007Un-Ij for qemu-devel@nongnu.org; Fri, 27 Jan 2012 09:43:59 -0500 Received: from mail-qw0-f45.google.com ([209.85.216.45]:40821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqn1v-0007Uj-Eb for qemu-devel@nongnu.org; Fri, 27 Jan 2012 09:43:55 -0500 Received: by qabg40 with SMTP id g40so690455qab.4 for ; Fri, 27 Jan 2012 06:43:55 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F22B81E.1030407@redhat.com> Date: Fri, 27 Jan 2012 15:43:42 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1327667215-5411-5-git-send-email-stefano.stabellini@eu.citrix.com> In-Reply-To: <1327667215-5411-5-git-send-email-stefano.stabellini@eu.citrix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, avi@redhat.com On 01/27/2012 01:26 PM, Stefano Stabellini wrote: > There is no reason why the minimum timeout should be 1sec, it could > easily be 1h and we would save lots of cpu cycles. > > Signed-off-by: Stefano Stabellini > --- > qemu-timer.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qemu-timer.c b/qemu-timer.c > index 648db1d..b792a32 100644 > --- a/qemu-timer.c > +++ b/qemu-timer.c > @@ -844,6 +844,6 @@ fail: > > int qemu_calculate_timeout(void) > { > - return 1000; > + return 1000*60*60; > } > This might break Windows networking, but I'm going to fix it before 1.1 anyway. Reviewed-by: Paolo Bonzini Paolo