From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqohs-0003e8-E3 for Qemu-devel@nongnu.org; Fri, 27 Jan 2012 11:31:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rqohn-0005c2-VJ for Qemu-devel@nongnu.org; Fri, 27 Jan 2012 11:31:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqohn-0005bt-HO for Qemu-devel@nongnu.org; Fri, 27 Jan 2012 11:31:15 -0500 Message-ID: <4F22D21B.8050302@redhat.com> Date: Fri, 27 Jan 2012 17:34:35 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <0F7A61B0A6ABAD4A82DDEF8CCA0ADA2B4E0906614F@AUSX7MCPS301.AMER.DELL.COM> <4F22CE9B.1000106@suse.de> In-Reply-To: <4F22CE9B.1000106@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] To support scsi Virtual Adapter while creating VMDK images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Alexander Graf , Praveen_Paladugu@Dell.com, Qemu-devel@nongnu.org, Soren Hansen , Aaron Mason Am 27.01.2012 17:19, schrieb Andreas F=E4rber: > Am 27.01.2012 00:46, schrieb Praveen_Paladugu@Dell.com: >> According to VMDK specification, while using virtual scsi adapter, the= value of adapterType has to be set to "lsilogic" or "buslogic". When the= user adds "scsi" to the list of qemu-img options (Example: qemu-img crea= te -f vmdk foo -o scsi,size=3D100M) this patch will set the value of adap= terType to "lsilogic". >> >> When the "scsi" is not passed, the default "ide" value is used. >=20 >> Signed-off-by: Praveen K Paladugu >=20 > SoB should be above the patch so that it gets committed. Please cc the > block maintainer, scripts/get_maintainer.pl can help with that. >=20 > We're carrying a pretty similar patch from 2009 in OBS: >=20 > https://build.opensuse.org/package/view_file?file=3Dqemu-img-vmdk-scsi.= patch&package=3Dvirt-utils&project=3DVirtualization&rev=3D34c58db02d6bfdb= 1a9dd49fc3c7fa9d4 >=20 > There were also patches by Soren Hansen and Kevin Wolf back in 2008, by > Pantelis Koukousoulas in 2009, by Aaron Mason and Alex Graf in 2010; ar= e > these all independent or is someone's SoB missing here? I think they are all independent. Aaron's patch came closest, it just had some coding style issues (I would fix these myself) and was missing a Signed-off-by (I can't do anything about that). The other patches (just like this one) all didn't allow both buslogic and lsilogic, but hardcoded one of them. Kevin