qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, avi@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 2/6] xen: disable rtc_clock
Date: Fri, 27 Jan 2012 21:08:44 +0100	[thread overview]
Message-ID: <4F23044C.3070209@redhat.com> (raw)
In-Reply-To: <1327688498-12362-2-git-send-email-stefano.stabellini@eu.citrix.com>

On 01/27/2012 07:21 PM, Stefano Stabellini wrote:
> rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen
> has its own RTC emulator in the hypervisor so we can disable it.
>
> Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
> ---
>   xen-all.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/xen-all.c b/xen-all.c
> index d1fc597..bf183f7 100644
> --- a/xen-all.c
> +++ b/xen-all.c
> @@ -513,6 +513,7 @@ void xen_vcpu_init(void)
>           qemu_register_reset(xen_reset_vcpu, first_cpu);
>           xen_reset_vcpu(first_cpu);
>       }
> +    qemu_clock_enable(rtc_clock, false);
>   }
>
>   /* get the ioreq packets from share mem */

I explained why this is wrong.

Paolo

  reply	other threads:[~2012-01-27 20:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27 18:20 [Qemu-devel] [PATCH v3 0/6] prevent Qemu from waking up needlessly Stefano Stabellini
2012-01-27 18:21 ` [Qemu-devel] [PATCH v3 1/6] xen: do not initialize the interval timer emulator Stefano Stabellini
2012-01-27 19:09   ` Jan Kiszka
2012-01-30 11:39     ` Stefano Stabellini
2012-01-30 15:13       ` Jan Kiszka
2012-01-27 18:21 ` [Qemu-devel] [PATCH v3 2/6] xen: disable rtc_clock Stefano Stabellini
2012-01-27 20:08   ` Paolo Bonzini [this message]
2012-01-30 11:58     ` Stefano Stabellini
2012-01-27 18:21 ` [Qemu-devel] [PATCH v3 3/6] xen: introduce an event channel for buffered io event notifications Stefano Stabellini
2012-01-27 18:21 ` [Qemu-devel] [PATCH v3 4/6] timers: the rearm function should be able to handle delta = INT64_MAX Stefano Stabellini
2012-01-27 18:21 ` [Qemu-devel] [PATCH v3 5/6] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled Stefano Stabellini
2012-01-27 18:21 ` [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h Stefano Stabellini
2012-02-10  0:26   ` Paul Brook
2012-02-10  8:03     ` Paolo Bonzini
2012-02-10  9:52       ` Paul Brook
2012-02-10 10:45         ` Paolo Bonzini
2012-02-10 11:09           ` Paul Brook
2012-02-10 11:19             ` Stefano Stabellini
2012-02-10 11:18               ` Paolo Bonzini
2012-02-10 11:32                 ` Jan Kiszka
2012-02-10 17:07                   ` Stefano Stabellini
2012-02-10 23:34                     ` Paul Brook
2012-02-13 11:52                       ` Stefano Stabellini
2012-02-14 10:52                         ` Paul Brook
2012-02-14 11:55                           ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F23044C.3070209@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).