From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqs6V-00012a-9X for qemu-devel@nongnu.org; Fri, 27 Jan 2012 15:09:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rqs6O-0005ev-SH for qemu-devel@nongnu.org; Fri, 27 Jan 2012 15:08:59 -0500 Received: from mail-ee0-f45.google.com ([74.125.83.45]:45209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqs6O-0005em-Md for qemu-devel@nongnu.org; Fri, 27 Jan 2012 15:08:52 -0500 Received: by eekd17 with SMTP id d17so818757eek.4 for ; Fri, 27 Jan 2012 12:08:50 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F23044C.3070209@redhat.com> Date: Fri, 27 Jan 2012 21:08:44 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1327688498-12362-2-git-send-email-stefano.stabellini@eu.citrix.com> In-Reply-To: <1327688498-12362-2-git-send-email-stefano.stabellini@eu.citrix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/6] xen: disable rtc_clock List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, avi@redhat.com On 01/27/2012 07:21 PM, Stefano Stabellini wrote: > rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen > has its own RTC emulator in the hypervisor so we can disable it. > > Signed-off-by: Stefano Stabellini > --- > xen-all.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/xen-all.c b/xen-all.c > index d1fc597..bf183f7 100644 > --- a/xen-all.c > +++ b/xen-all.c > @@ -513,6 +513,7 @@ void xen_vcpu_init(void) > qemu_register_reset(xen_reset_vcpu, first_cpu); > xen_reset_vcpu(first_cpu); > } > + qemu_clock_enable(rtc_clock, false); > } > > /* get the ioreq packets from share mem */ I explained why this is wrong. Paolo