From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqs8f-0003CN-S2 for qemu-devel@nongnu.org; Fri, 27 Jan 2012 15:11:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rqs8e-00061e-QM for qemu-devel@nongnu.org; Fri, 27 Jan 2012 15:11:13 -0500 Received: from smtp1-g21.free.fr ([212.27.42.1]:53872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqs8e-000616-4l for qemu-devel@nongnu.org; Fri, 27 Jan 2012 15:11:12 -0500 Message-ID: <4F2304DB.2070105@reactos.org> Date: Fri, 27 Jan 2012 21:11:07 +0100 From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= MIME-Version: 1.0 References: <1327308641-14736-1-git-send-email-hpoussin@reactos.org> <1327308641-14736-2-git-send-email-hpoussin@reactos.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 1/9] fdc: take side count into account List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , qemu-devel@nongnu.org Markus Armbruster a =C3=A9crit : > Herv=C3=A9 Poussineau writes: >=20 >> Floppies can be simple or double-sided. However, current code >> was only taking the common case into account (ie 2 sides). >=20 > Impact? This repairs single-sided floppies > Are single sided floppies broken before the patch? How? Yes. For head > 0, wrong sector number is calculated, so data is=20 read/written at wrong place on underlying block device. Fortunately, mostly nobody is still using single-sided floppies (only=20 some 360 kB floppies are single-sided), so bug has been neglected since=20 a long time. Herv=C3=A9