* [Qemu-devel] suspend/resume not working on tip due to 59abb06
@ 2012-01-27 21:10 Stefan Berger
2012-01-27 21:27 ` Stefan Berger
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Berger @ 2012-01-27 21:10 UTC (permalink / raw)
To: qemu-devel, blauwirbel
After bisecting the following commit seems to be the culprit for the
suspend/resume problems that I am seeing with the current tip
(73093354418602a2ff5e43cb91a21b17fbf047d8).
commit 59abb06198ee9471e29c970f294eae80c0b39be1
Author: Blue Swirl <blauwirbel@gmail.com>
Date: Sun Jan 22 11:00:44 2012 +0000
Once I revert this patch on the tip everything works fine again...
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] suspend/resume not working on tip due to 59abb06
2012-01-27 21:10 [Qemu-devel] suspend/resume not working on tip due to 59abb06 Stefan Berger
@ 2012-01-27 21:27 ` Stefan Berger
2012-01-28 12:23 ` Blue Swirl
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Berger @ 2012-01-27 21:27 UTC (permalink / raw)
To: qemu-devel, blauwirbel
On 01/27/2012 04:10 PM, Stefan Berger wrote:
> After bisecting the following commit seems to be the culprit for the
> suspend/resume problems that I am seeing with the current tip
> (73093354418602a2ff5e43cb91a21b17fbf047d8).
>
> commit 59abb06198ee9471e29c970f294eae80c0b39be1
> Author: Blue Swirl <blauwirbel@gmail.com>
> Date: Sun Jan 22 11:00:44 2012 +0000
>
> Once I revert this patch on the tip everything works fine again...
>
> Stefan
>
>
And this patch here gets it to work:
diff --git a/exec-obsolete.h b/exec-obsolete.h
index 03cf35e..a673386 100644
--- a/exec-obsolete.h
+++ b/exec-obsolete.h
@@ -101,7 +101,7 @@ static inline void
cpu_physical_memory_mask_dirty_range(ram_
end = start + length;
mask = ~dirty_flags;
p = ram_list.phys_dirty + (start >> TARGET_PAGE_BITS);
- for (addr = start; addr <= end; addr += TARGET_PAGE_SIZE) {
+ for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
*p++ &= mask;
}
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] suspend/resume not working on tip due to 59abb06
2012-01-27 21:27 ` Stefan Berger
@ 2012-01-28 12:23 ` Blue Swirl
2012-01-28 17:57 ` Blue Swirl
0 siblings, 1 reply; 4+ messages in thread
From: Blue Swirl @ 2012-01-28 12:23 UTC (permalink / raw)
To: Stefan Berger, Avi Kivity; +Cc: qemu-devel
On Fri, Jan 27, 2012 at 21:27, Stefan Berger <stefanb@linux.vnet.ibm.com> wrote:
> On 01/27/2012 04:10 PM, Stefan Berger wrote:
>>
>> After bisecting the following commit seems to be the culprit for the
>> suspend/resume problems that I am seeing with the current tip
>> (73093354418602a2ff5e43cb91a21b17fbf047d8).
>>
>> commit 59abb06198ee9471e29c970f294eae80c0b39be1
>> Author: Blue Swirl <blauwirbel@gmail.com>
>> Date: Sun Jan 22 11:00:44 2012 +0000
>>
>> Once I revert this patch on the tip everything works fine again...
>>
>> Stefan
>>
>>
> And this patch here gets it to work:
>
> diff --git a/exec-obsolete.h b/exec-obsolete.h
> index 03cf35e..a673386 100644
> --- a/exec-obsolete.h
> +++ b/exec-obsolete.h
> @@ -101,7 +101,7 @@ static inline void
> cpu_physical_memory_mask_dirty_range(ram_
> end = start + length;
> mask = ~dirty_flags;
> p = ram_list.phys_dirty + (start >> TARGET_PAGE_BITS);
> - for (addr = start; addr <= end; addr += TARGET_PAGE_SIZE) {
> + for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
> *p++ &= mask;
> }
> }
Nice. Please add a description (something like "Fix suspend/resume
broken by off-by-one error in 7309...") and Signed-off-by: line.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] suspend/resume not working on tip due to 59abb06
2012-01-28 12:23 ` Blue Swirl
@ 2012-01-28 17:57 ` Blue Swirl
0 siblings, 0 replies; 4+ messages in thread
From: Blue Swirl @ 2012-01-28 17:57 UTC (permalink / raw)
To: Stefan Berger, Avi Kivity; +Cc: qemu-devel
On Sat, Jan 28, 2012 at 12:23, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Fri, Jan 27, 2012 at 21:27, Stefan Berger <stefanb@linux.vnet.ibm.com> wrote:
>> On 01/27/2012 04:10 PM, Stefan Berger wrote:
>>>
>>> After bisecting the following commit seems to be the culprit for the
>>> suspend/resume problems that I am seeing with the current tip
>>> (73093354418602a2ff5e43cb91a21b17fbf047d8).
>>>
>>> commit 59abb06198ee9471e29c970f294eae80c0b39be1
>>> Author: Blue Swirl <blauwirbel@gmail.com>
>>> Date: Sun Jan 22 11:00:44 2012 +0000
>>>
>>> Once I revert this patch on the tip everything works fine again...
>>>
>>> Stefan
>>>
>>>
>> And this patch here gets it to work:
>>
>> diff --git a/exec-obsolete.h b/exec-obsolete.h
>> index 03cf35e..a673386 100644
>> --- a/exec-obsolete.h
>> +++ b/exec-obsolete.h
>> @@ -101,7 +101,7 @@ static inline void
>> cpu_physical_memory_mask_dirty_range(ram_
>> end = start + length;
>> mask = ~dirty_flags;
>> p = ram_list.phys_dirty + (start >> TARGET_PAGE_BITS);
>> - for (addr = start; addr <= end; addr += TARGET_PAGE_SIZE) {
>> + for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
>> *p++ &= mask;
>> }
>> }
>
> Nice. Please add a description (something like "Fix suspend/resume
> broken by off-by-one error in 7309...") and Signed-off-by: line.
On second thought, the code is also broken for case start =
(ram_addr_t)-TARGET_PAGE_SIZE, length = TARGET_PAGE_SIZE. I'll make
another patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-28 17:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-27 21:10 [Qemu-devel] suspend/resume not working on tip due to 59abb06 Stefan Berger
2012-01-27 21:27 ` Stefan Berger
2012-01-28 12:23 ` Blue Swirl
2012-01-28 17:57 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).