qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: qemu-devel <qemu-devel@nongnu.org>, blauwirbel@gmail.com
Subject: Re: [Qemu-devel] suspend/resume not working on tip due to 59abb06
Date: Fri, 27 Jan 2012 16:27:37 -0500	[thread overview]
Message-ID: <4F2316C9.70807@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F2312D4.1050408@linux.vnet.ibm.com>

On 01/27/2012 04:10 PM, Stefan Berger wrote:
> After bisecting the following commit seems to be the culprit for the 
> suspend/resume problems that I am seeing with the current tip 
> (73093354418602a2ff5e43cb91a21b17fbf047d8).
>
> commit 59abb06198ee9471e29c970f294eae80c0b39be1
> Author: Blue Swirl <blauwirbel@gmail.com>
> Date:   Sun Jan 22 11:00:44 2012 +0000
>
> Once I revert this patch on the tip everything works fine again...
>
>    Stefan
>
>
And this patch here gets it to work:

diff --git a/exec-obsolete.h b/exec-obsolete.h
index 03cf35e..a673386 100644
--- a/exec-obsolete.h
+++ b/exec-obsolete.h
@@ -101,7 +101,7 @@ static inline void 
cpu_physical_memory_mask_dirty_range(ram_
      end = start + length;
      mask = ~dirty_flags;
      p = ram_list.phys_dirty + (start >> TARGET_PAGE_BITS);
-    for (addr = start; addr <= end; addr += TARGET_PAGE_SIZE) {
+    for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
          *p++ &= mask;
      }
  }

  reply	other threads:[~2012-01-27 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27 21:10 [Qemu-devel] suspend/resume not working on tip due to 59abb06 Stefan Berger
2012-01-27 21:27 ` Stefan Berger [this message]
2012-01-28 12:23   ` Blue Swirl
2012-01-28 17:57     ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2316C9.70807@linux.vnet.ibm.com \
    --to=stefanb@linux.vnet.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).