From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqufA-0001w2-83 for qemu-devel@nongnu.org; Fri, 27 Jan 2012 17:52:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rquf9-0003ZN-1F for qemu-devel@nongnu.org; Fri, 27 Jan 2012 17:52:56 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:56213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rquf8-0003ZG-Gd for qemu-devel@nongnu.org; Fri, 27 Jan 2012 17:52:54 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate02.web.de (Postfix) with ESMTP id 656E01C077444 for ; Fri, 27 Jan 2012 23:52:53 +0100 (CET) Message-ID: <4F232AC4.8010103@web.de> Date: Fri, 27 Jan 2012 23:52:52 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <425113312.536860.1327583430249.JavaMail.open-xchange@email.1und1.de> In-Reply-To: <425113312.536860.1327583430249.JavaMail.open-xchange@email.1und1.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5D01E9AEAF2E720AF35C24DD" Subject: Re: [Qemu-devel] git bisect results List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Erik Rull Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5D01E9AEAF2E720AF35C24DD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-01-26 14:10, Erik Rull wrote: > I assume from these results that the gui_grab is never set to 1 when ha= ving=20 > entered the window in windowed mode with the cursor. >=20 > Maybe that's why the sdl_grab_start() is called so often. >=20 > It seems that the condition in sdl_grab_start() (SDL_WM_GrabInput(SDL_G= RAB_ON)=20 > =3D=3D SDL_GRAB_ON) is never fulfilled, otherwise the gui_grab would be= set to 1.=20 > But the cursor is actually grabbed in windowed mode, otherwise I would = not be=20 > able to click somewhere with the guest-windows-cursor. This might be a SDL limitation which does not show up everywhere. Here it's fine e.g. The logic dates back to "Handle SDL grabs failing (Mark McLoughlin)", 6bb816031f. Maybe we can solve that issue without relying on the obviously unreliable return value. Need to reproduce that one as well, though. Jan --------------enig5D01E9AEAF2E720AF35C24DD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8jKsQACgkQitSsb3rl5xQdXwCfRvtEfS/XWKyB+A4MYJWW7MJC z7AAoJInLNi+s1Ayg5GDbcn+mRQxYSUi =nNHo -----END PGP SIGNATURE----- --------------enig5D01E9AEAF2E720AF35C24DD--