From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr6se-0004SA-Du for qemu-devel@nongnu.org; Sat, 28 Jan 2012 06:55:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rr6sb-0001WA-KD for qemu-devel@nongnu.org; Sat, 28 Jan 2012 06:55:40 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:51258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr6sb-0001W3-AZ for qemu-devel@nongnu.org; Sat, 28 Jan 2012 06:55:37 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate03.web.de (Postfix) with ESMTP id 590551B079F21 for ; Sat, 28 Jan 2012 12:55:36 +0100 (CET) Message-ID: <4F23E237.7020904@web.de> Date: Sat, 28 Jan 2012 12:55:35 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <425113312.536860.1327583430249.JavaMail.open-xchange@email.1und1.de> <4F232AC4.8010103@web.de> In-Reply-To: <4F232AC4.8010103@web.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4BE610ED1BB62AC847488BA3" Subject: Re: [Qemu-devel] git bisect results List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Erik Rull Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4BE610ED1BB62AC847488BA3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-01-27 23:52, Jan Kiszka wrote: > On 2012-01-26 14:10, Erik Rull wrote: >> I assume from these results that the gui_grab is never set to 1 when h= aving=20 >> entered the window in windowed mode with the cursor. >> >> Maybe that's why the sdl_grab_start() is called so often. >> >> It seems that the condition in sdl_grab_start() (SDL_WM_GrabInput(SDL_= GRAB_ON)=20 >> =3D=3D SDL_GRAB_ON) is never fulfilled, otherwise the gui_grab would b= e set to 1.=20 >> But the cursor is actually grabbed in windowed mode, otherwise I would= not be=20 >> able to click somewhere with the guest-windows-cursor. >=20 > This might be a SDL limitation which does not show up everywhere. Here > it's fine e.g. >=20 > The logic dates back to "Handle SDL grabs failing (Mark McLoughlin)", > 6bb816031f. Maybe we can solve that issue without relying on the > obviously unreliable return value. Need to reproduce that one as well, > though. Please check if git://git.kiszka.org/qemu.git queues/sdl fixes the issue for you. Namely reverting the above commit should do the trick. I obsoleted that fragile patch in my series. Thanks, Jan --------------enig4BE610ED1BB62AC847488BA3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8j4jcACgkQitSsb3rl5xRpTgCeOvxzu5oWxF/rH/yY7cuf0PFn d24AoMSeBabDmgX8hVj8fX3iPT6wNaZd =Kwi7 -----END PGP SIGNATURE----- --------------enig4BE610ED1BB62AC847488BA3--