From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54030)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <erik.rull@rdsoftware.de>) id 1Rr7Yk-0005yc-DI
	for qemu-devel@nongnu.org; Sat, 28 Jan 2012 07:39:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <erik.rull@rdsoftware.de>) id 1Rr7Yj-0006dA-7w
	for qemu-devel@nongnu.org; Sat, 28 Jan 2012 07:39:10 -0500
Received: from moutng.kundenserver.de ([212.227.17.10]:49286)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <erik.rull@rdsoftware.de>) id 1Rr7Yi-0006cx-PX
	for qemu-devel@nongnu.org; Sat, 28 Jan 2012 07:39:09 -0500
Message-ID: <4F23EC69.3030508@rdsoftware.de>
Date: Sat, 28 Jan 2012 13:39:05 +0100
From: Erik Rull <erik.rull@rdsoftware.de>
MIME-Version: 1.0
References: <425113312.536860.1327583430249.JavaMail.open-xchange@email.1und1.de>
	<4F232AC4.8010103@web.de> <4F23E237.7020904@web.de>
In-Reply-To: <4F23E237.7020904@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] git bisect results
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org

Jan Kiszka wrote:
> On 2012-01-27 23:52, Jan Kiszka wrote:
>> On 2012-01-26 14:10, Erik Rull wrote:
>>> I assume from these results that the gui_grab is never set to 1 when having
>>> entered the window in windowed mode with the cursor.
>>>
>>> Maybe that's why the sdl_grab_start() is called so often.
>>>
>>> It seems that the condition in sdl_grab_start() (SDL_WM_GrabInput(SDL_GRAB_ON)
>>> == SDL_GRAB_ON) is never fulfilled, otherwise the gui_grab would be set to 1.
>>> But the cursor is actually grabbed in windowed mode, otherwise I would not be
>>> able to click somewhere with the guest-windows-cursor.
>>
>> This might be a SDL limitation which does not show up everywhere. Here
>> it's fine e.g.
>>
>> The logic dates back to "Handle SDL grabs failing (Mark McLoughlin)",
>> 6bb816031f. Maybe we can solve that issue without relying on the
>> obviously unreliable return value. Need to reproduce that one as well,
>> though.
>
> Please check if
>
> git://git.kiszka.org/qemu.git queues/sdl
>
> fixes the issue for you. Namely reverting the above commit should do the
> trick. I obsoleted that fragile patch in my series.
>
> Thanks,
> Jan
>
>

Hi Jan,

I will test this on monday. Can you tell me how I can merge that into my 
cloned main qemu repository? I'm quite new to git.

Thanks.

Best regards,

Erik