From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr7cx-0007Nx-7N for qemu-devel@nongnu.org; Sat, 28 Jan 2012 07:43:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rr7cs-00070V-VY for qemu-devel@nongnu.org; Sat, 28 Jan 2012 07:43:31 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:48825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr7cs-00070O-Ma for qemu-devel@nongnu.org; Sat, 28 Jan 2012 07:43:26 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate02.web.de (Postfix) with ESMTP id 794211C07E85F for ; Sat, 28 Jan 2012 13:43:25 +0100 (CET) Message-ID: <4F23ED6A.1010602@web.de> Date: Sat, 28 Jan 2012 13:43:22 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <425113312.536860.1327583430249.JavaMail.open-xchange@email.1und1.de> <4F232AC4.8010103@web.de> <4F23E237.7020904@web.de> <4F23EC69.3030508@rdsoftware.de> In-Reply-To: <4F23EC69.3030508@rdsoftware.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB0F5A6721A01D90DD9CFAFB7" Subject: Re: [Qemu-devel] git bisect results List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Erik Rull Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB0F5A6721A01D90DD9CFAFB7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-01-28 13:39, Erik Rull wrote: > Jan Kiszka wrote: >> On 2012-01-27 23:52, Jan Kiszka wrote: >>> On 2012-01-26 14:10, Erik Rull wrote: >>>> I assume from these results that the gui_grab is never set to 1 when= >>>> having >>>> entered the window in windowed mode with the cursor. >>>> >>>> Maybe that's why the sdl_grab_start() is called so often. >>>> >>>> It seems that the condition in sdl_grab_start() >>>> (SDL_WM_GrabInput(SDL_GRAB_ON) >>>> =3D=3D SDL_GRAB_ON) is never fulfilled, otherwise the gui_grab would= be >>>> set to 1. >>>> But the cursor is actually grabbed in windowed mode, otherwise I >>>> would not be >>>> able to click somewhere with the guest-windows-cursor. >>> >>> This might be a SDL limitation which does not show up everywhere. Her= e >>> it's fine e.g. >>> >>> The logic dates back to "Handle SDL grabs failing (Mark McLoughlin)",= >>> 6bb816031f. Maybe we can solve that issue without relying on the >>> obviously unreliable return value. Need to reproduce that one as well= , >>> though. >> >> Please check if >> >> git://git.kiszka.org/qemu.git queues/sdl >> >> fixes the issue for you. Namely reverting the above commit should do t= he >> trick. I obsoleted that fragile patch in my series. >> >> Thanks, >> Jan >> >> >=20 > Hi Jan, >=20 > I will test this on monday. Can you tell me how I can merge that into m= y > cloned main qemu repository? I'm quite new to git. # git remote add kiszka git://git.kiszka.org/qemu.git # git fetch kiszka # git checkout kiszka/queues/sdl That way you will have what I have. Or do you need additional patches for your tests? Jan --------------enigB0F5A6721A01D90DD9CFAFB7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8j7WoACgkQitSsb3rl5xTX2gCeN/OhCoWuLdidiVJpGlz8SUqD qgwAoMWZxAfIET4UUCVtWb6kP6cN4wew =/X1w -----END PGP SIGNATURE----- --------------enigB0F5A6721A01D90DD9CFAFB7--