From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr7u5-0002Bc-Jg for qemu-devel@nongnu.org; Sat, 28 Jan 2012 08:01:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rr7tz-0000U1-O2 for qemu-devel@nongnu.org; Sat, 28 Jan 2012 08:01:12 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:50207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr7ty-0000T7-QG for qemu-devel@nongnu.org; Sat, 28 Jan 2012 08:01:07 -0500 Message-ID: <4F23F196.9040404@rdsoftware.de> Date: Sat, 28 Jan 2012 14:01:10 +0100 From: Erik Rull MIME-Version: 1.0 References: <425113312.536860.1327583430249.JavaMail.open-xchange@email.1und1.de> <4F232AC4.8010103@web.de> <4F23E237.7020904@web.de> <4F23EC69.3030508@rdsoftware.de> <4F23ED6A.1010602@web.de> In-Reply-To: <4F23ED6A.1010602@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] git bisect results List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org Jan Kiszka wrote: > On 2012-01-28 13:39, Erik Rull wrote: >> Jan Kiszka wrote: >>> On 2012-01-27 23:52, Jan Kiszka wrote: >>>> On 2012-01-26 14:10, Erik Rull wrote: >>>>> I assume from these results that the gui_grab is never set to 1 when >>>>> having >>>>> entered the window in windowed mode with the cursor. >>>>> >>>>> Maybe that's why the sdl_grab_start() is called so often. >>>>> >>>>> It seems that the condition in sdl_grab_start() >>>>> (SDL_WM_GrabInput(SDL_GRAB_ON) >>>>> == SDL_GRAB_ON) is never fulfilled, otherwise the gui_grab would be >>>>> set to 1. >>>>> But the cursor is actually grabbed in windowed mode, otherwise I >>>>> would not be >>>>> able to click somewhere with the guest-windows-cursor. >>>> >>>> This might be a SDL limitation which does not show up everywhere. Here >>>> it's fine e.g. >>>> >>>> The logic dates back to "Handle SDL grabs failing (Mark McLoughlin)", >>>> 6bb816031f. Maybe we can solve that issue without relying on the >>>> obviously unreliable return value. Need to reproduce that one as well, >>>> though. >>> >>> Please check if >>> >>> git://git.kiszka.org/qemu.git queues/sdl >>> >>> fixes the issue for you. Namely reverting the above commit should do the >>> trick. I obsoleted that fragile patch in my series. >>> >>> Thanks, >>> Jan >>> >>> >> >> Hi Jan, >> >> I will test this on monday. Can you tell me how I can merge that into my >> cloned main qemu repository? I'm quite new to git. > > # git remote add kiszka git://git.kiszka.org/qemu.git > # git fetch kiszka > # git checkout kiszka/queues/sdl > > That way you will have what I have. Or do you need additional patches > for your tests? > > Jan > No I think this will be sufficient. Will this work if I will add it to the qemu-kvm-1.0 tagged version? I have further issues when using the current master because this version does not boot up Windows XP at the moment. I was not able to bisect up to now where this issue was added. Best regards, Erik