From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr9dm-0004FT-Lu for qemu-devel@nongnu.org; Sat, 28 Jan 2012 09:52:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rr9dl-0006Z2-5i for qemu-devel@nongnu.org; Sat, 28 Jan 2012 09:52:30 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:52282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr9dk-0006Ys-K9 for qemu-devel@nongnu.org; Sat, 28 Jan 2012 09:52:29 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate01.web.de (Postfix) with ESMTP id 1687C1A9B4948 for ; Sat, 28 Jan 2012 15:52:22 +0100 (CET) Message-ID: <4F240BA4.8060601@web.de> Date: Sat, 28 Jan 2012 15:52:20 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <425113312.536860.1327583430249.JavaMail.open-xchange@email.1und1.de> <4F232AC4.8010103@web.de> <4F23E237.7020904@web.de> <4F23EC69.3030508@rdsoftware.de> <4F23ED6A.1010602@web.de> <4F23F196.9040404@rdsoftware.de> In-Reply-To: <4F23F196.9040404@rdsoftware.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA5F702656BF9B5EDFBE2EDAB" Subject: Re: [Qemu-devel] git bisect results List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Erik Rull Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA5F702656BF9B5EDFBE2EDAB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-01-28 14:01, Erik Rull wrote: > Jan Kiszka wrote: >> On 2012-01-28 13:39, Erik Rull wrote: >>> Jan Kiszka wrote: >>>> On 2012-01-27 23:52, Jan Kiszka wrote: >>>>> On 2012-01-26 14:10, Erik Rull wrote: >>>>>> I assume from these results that the gui_grab is never set to 1 wh= en >>>>>> having >>>>>> entered the window in windowed mode with the cursor. >>>>>> >>>>>> Maybe that's why the sdl_grab_start() is called so often. >>>>>> >>>>>> It seems that the condition in sdl_grab_start() >>>>>> (SDL_WM_GrabInput(SDL_GRAB_ON) >>>>>> =3D=3D SDL_GRAB_ON) is never fulfilled, otherwise the gui_grab wou= ld be >>>>>> set to 1. >>>>>> But the cursor is actually grabbed in windowed mode, otherwise I >>>>>> would not be >>>>>> able to click somewhere with the guest-windows-cursor. >>>>> >>>>> This might be a SDL limitation which does not show up everywhere. H= ere >>>>> it's fine e.g. >>>>> >>>>> The logic dates back to "Handle SDL grabs failing (Mark McLoughlin)= ", >>>>> 6bb816031f. Maybe we can solve that issue without relying on the >>>>> obviously unreliable return value. Need to reproduce that one as we= ll, >>>>> though. >>>> >>>> Please check if >>>> >>>> git://git.kiszka.org/qemu.git queues/sdl >>>> >>>> fixes the issue for you. Namely reverting the above commit should do= >>>> the >>>> trick. I obsoleted that fragile patch in my series. >>>> >>>> Thanks, >>>> Jan >>>> >>>> >>> >>> Hi Jan, >>> >>> I will test this on monday. Can you tell me how I can merge that into= my >>> cloned main qemu repository? I'm quite new to git. >> >> # git remote add kiszka git://git.kiszka.org/qemu.git >> # git fetch kiszka >> # git checkout kiszka/queues/sdl >> >> That way you will have what I have. Or do you need additional patches >> for your tests? >> >> Jan >> >=20 > No I think this will be sufficient. Will this work if I will add it to > the qemu-kvm-1.0 tagged version? For your test, you can focus on applying http://git.kiszka.org/?p=3Dqemu.git;a=3Dcommitdiff;h=3D0109c860ca59fddbec= b47651be3cbf5135d8e82e on the target branch. > I have further issues when using the > current master because this version does not boot up Windows XP at the > moment. I was not able to bisect up to now where this issue was added. Hmm, works here. Which command line? Jan --------------enigA5F702656BF9B5EDFBE2EDAB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8kC6UACgkQitSsb3rl5xSkBwCeIzjsxDzQ+7PfY7BOsWWbFxqY IqEAn3SuBu+MDxeZfWOc3OWib81rvU6C =QrMA -----END PGP SIGNATURE----- --------------enigA5F702656BF9B5EDFBE2EDAB--