From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50453)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RrTYe-0004r9-7R
	for qemu-devel@nongnu.org; Sun, 29 Jan 2012 07:08:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RrTYd-0007qn-5H
	for qemu-devel@nongnu.org; Sun, 29 Jan 2012 07:08:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52048)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RrTYc-0007qi-V0
	for qemu-devel@nongnu.org; Sun, 29 Jan 2012 07:08:31 -0500
Message-ID: <4F2536B9.4070305@redhat.com>
Date: Sun, 29 Jan 2012 14:08:25 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <CAAu8pHtQYSXayKD72jcEdbEPiiA_ucD9UWVoT=h=5sOpXWN3Sw@mail.gmail.com>
In-Reply-To: <CAAu8pHtQYSXayKD72jcEdbEPiiA_ucD9UWVoT=h=5sOpXWN3Sw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] exec-obsolete: fix length handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Stefan Berger <stefanb@linux.vnet.ibm.com>

On 01/28/2012 08:13 PM, Blue Swirl wrote:
> Fix suspend/resume broken by off-by-one error in
> 59abb06198ee9471e29c970f294eae80c0b39be1.
>
> Adjust the loop so that it handles correctly the case
> start = (ram_addr_t)-TARGET_PAGE_SIZE, length = TARGET_PAGE_SIZE.
>
> Reported-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
>  exec-obsolete.h |   10 ++++------
>  1 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/exec-obsolete.h b/exec-obsolete.h
> index 03cf35e..1bba970 100644
> --- a/exec-obsolete.h
> +++ b/exec-obsolete.h
> @@ -81,11 +81,10 @@ static inline void
> cpu_physical_memory_set_dirty_range(ram_addr_t start,
>                                                         int dirty_flags)
>  {
>      uint8_t *p;
> -    ram_addr_t addr, end;
> +    ram_addr_t cur;
>
> -    end = start + length;
>      p = ram_list.phys_dirty + (start >> TARGET_PAGE_BITS);
> -    for (addr = start; addr <= end; addr += TARGET_PAGE_SIZE) {
> +    for (cur = 0; cur < length; cur += TARGET_PAGE_SIZE) {
>          *p++ |= dirty_flags;
>      }

I think this is still wrong - if length == 2 it will iterate once, but
we need two iterations if start == 0xfff.


-- 
error compiling committee.c: too many arguments to function