From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rrgn1-0001TQ-85
	for qemu-devel@nongnu.org; Sun, 29 Jan 2012 21:16:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rrgn0-0001cJ-6b
	for qemu-devel@nongnu.org; Sun, 29 Jan 2012 21:16:15 -0500
Received: from mail-yx0-f173.google.com ([209.85.213.173]:35434)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rrgn0-0001cE-1q
	for qemu-devel@nongnu.org; Sun, 29 Jan 2012 21:16:14 -0500
Received: by yenl8 with SMTP id l8so1992838yen.4
	for <qemu-devel@nongnu.org>; Sun, 29 Jan 2012 18:16:13 -0800 (PST)
Message-ID: <4F25FD6B.6010102@codemonkey.ws>
Date: Sun, 29 Jan 2012 20:16:11 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1327843531-32403-1-git-send-email-afaerber@suse.de>
	<1327843531-32403-6-git-send-email-afaerber@suse.de>
In-Reply-To: <1327843531-32403-6-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH RFC 5/7] cpu: Introduce cpu_class_foreach()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org

On 01/29/2012 07:25 AM, Andreas Färber wrote:
> Provides an easy way to loop over all non-abstract CPU classes.
>
> Signed-off-by: Andreas Färber<afaerber@suse.de>

I have a patch in my next series which provides an interface for this.

https://github.com/aliguori/qemu/commit/42ab3f78477307438591c77816f06f12cf9d9fc0

I'll post a proper version tomorrow.

Regards,

Anthony Liguori

> ---
>   hw/cpu.c           |   25 +++++++++++++++++++++++++
>   include/qemu/cpu.h |    9 +++++++++
>   2 files changed, 34 insertions(+), 0 deletions(-)
>
> diff --git a/hw/cpu.c b/hw/cpu.c
> index c0e9cfa..ac0add7 100644
> --- a/hw/cpu.c
> +++ b/hw/cpu.c
> @@ -11,6 +11,31 @@
>   #include "qemu/cpu.h"
>   #include "qemu-common.h"
>
> +struct CPUListData {
> +    void (*fn)(ObjectClass *klass, void *opaque);
> +    void *opaque;
> +};
> +
> +static void cpu_class_foreach_tramp(ObjectClass *klass, void *opaque)
> +{
> +    struct CPUListData *s = opaque;
> +
> +    if (!object_class_is_abstract(klass)&&
> +        object_class_dynamic_cast(klass, TYPE_CPU) != NULL) {
> +        s->fn(klass, s->opaque);
> +    }
> +}
> +
> +void cpu_class_foreach(void (*fn)(ObjectClass *klass, void *opaque),
> +                       void *opaque)
> +{
> +    struct CPUListData s = {
> +        .fn = fn,
> +        .opaque = opaque,
> +    };
> +    object_class_foreach(cpu_class_foreach_tramp,&s);
> +}
> +
>   static TypeInfo cpu_type_info = {
>       .name = TYPE_CPU,
>       .parent = TYPE_OBJECT,
> diff --git a/include/qemu/cpu.h b/include/qemu/cpu.h
> index 4b81f3b..d06c87e 100644
> --- a/include/qemu/cpu.h
> +++ b/include/qemu/cpu.h
> @@ -24,4 +24,13 @@ typedef struct CPU {
>   } CPU;
>
>
> +/**
> + * cpu_class_foreach:
> + * @fn: Callback function called for each non-abstract CPU type.
> + * @opaque: Opaque data passed through to the callback function.
> + */
> +void cpu_class_foreach(void (*fn)(ObjectClass *klass, void *opaque),
> +                       void *opaque);
> +
> +
>   #endif