From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53178)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RrpmY-0005Tz-6d
	for qemu-devel@nongnu.org; Mon, 30 Jan 2012 06:52:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RrpmX-0002bc-5D
	for qemu-devel@nongnu.org; Mon, 30 Jan 2012 06:52:22 -0500
Received: from goliath.siemens.de ([192.35.17.28]:32877)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RrpmW-0002bP-QQ
	for qemu-devel@nongnu.org; Mon, 30 Jan 2012 06:52:21 -0500
Message-ID: <4F268471.6040803@siemens.com>
Date: Mon, 30 Jan 2012 12:52:17 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1354816477.730358.1327923250151.JavaMail.open-xchange@email.1und1.de>
In-Reply-To: <1354816477.730358.1327923250151.JavaMail.open-xchange@email.1und1.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] git bisect results
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Erik Rull <erik.rull@rdsoftware.de>
Cc: qemu-devel@nongnu.org

On 2012-01-30 12:34, Erik Rull wrote:
> Hi Jan,
> 
> I'm sorry, but this does not solve my issue. I applied the patch and 
> crosschecked that the resulting file looks fine.
> 
> The final function looks like:
> 
> static void sdl_grab_start(void)
> {
> /*
> * If the application is not active, do not try to enter grab state. This
> * prevents 'SDL_WM_GrabInput(SDL_GRAB_ON)' from blocking all the
> * application (SDL bug).
> */
> if (!(SDL_GetAppState() & SDL_APPINPUTFOCUS)) {
> return;
> }
> if (guest_cursor) {
> SDL_SetCursor(guest_sprite);
> if (!kbd_mouse_is_absolute() && !absolute_enabled)
> SDL_WarpMouse(guest_x, guest_y);
> } else
> sdl_hide_cursor();
> SDL_WM_GrabInput(SDL_GRAB_ON);
> gui_grab = 1;
> sdl_update_caption();
> }

That makes no sense as gui_grab must be 1 now. Please retry your
previous instrumentation.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux