From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rrpu0-0008H4-Ca for qemu-devel@nongnu.org; Mon, 30 Jan 2012 07:00:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rrpts-0003lb-8a for qemu-devel@nongnu.org; Mon, 30 Jan 2012 07:00:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rrpts-0003lW-21 for qemu-devel@nongnu.org; Mon, 30 Jan 2012 06:59:56 -0500 Message-ID: <4F268632.8040801@redhat.com> Date: Mon, 30 Jan 2012 12:59:46 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1327667215-5411-2-git-send-email-stefano.stabellini@eu.citrix.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com" , "qemu-devel@nongnu.org" On 01/30/2012 12:56 PM, Stefano Stabellini wrote: >> > Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true. > > Good point. > I should check for rtc_clock == host_clock. > >> > Why do you need to instantiate an RTC at all? > I don't, in fact in previous versions of this patch series I tried to do > that but it is difficult and makes the common code worse, so I followed > Anthony's suggestion of just disabling the rtc_clock. I see. It shouldn't surprise you that I completely disagree with Anthony on this. :) Paolo