From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrtaN-0007Yq-9Z for qemu-devel@nongnu.org; Mon, 30 Jan 2012 10:56:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RrtaH-0000AG-NM for qemu-devel@nongnu.org; Mon, 30 Jan 2012 10:56:03 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:62960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrtaH-0000AC-Dy for qemu-devel@nongnu.org; Mon, 30 Jan 2012 10:55:57 -0500 Received: by iahk25 with SMTP id k25so6896013iah.4 for ; Mon, 30 Jan 2012 07:55:56 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F26BD84.3050403@redhat.com> Date: Mon, 30 Jan 2012 16:55:48 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20120124161628.4bf2592c@doriath.home> <4F1F0E9F.8080302@redhat.com> <4F1FC030.2030705@redhat.com> <20120125104204.55eec0a1@doriath.home> <20120126155757.3e97a0c1@doriath.home> <4F2273CF.3050107@redhat.com> <20120130131843.7f88117a@doriath> <4F26BA9A.1050705@redhat.com> In-Reply-To: <4F26BA9A.1050705@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Markus Armbruster , Eric Blake , qemu-devel , Luiz Capitulino On 01/30/2012 04:43 PM, Kevin Wolf wrote: >>> >> >>> >> If we had force=true in the initial eject command, bdrv_close is called, >>> >> which in turn goes through bdrv_dev_change_media_cb where an event is >>> >> emitted. >> > >> > Can't this race with the guest eject? > Can't see how, there's nothing asynchronous in the path. The button press is sent down to the guest even with -f. Paolo