From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49231)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Rs96s-00051f-O6
	for qemu-devel@nongnu.org; Tue, 31 Jan 2012 03:30:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Rs96f-0002eX-N3
	for qemu-devel@nongnu.org; Tue, 31 Jan 2012 03:30:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:21957)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Rs96f-0002eK-F7
	for qemu-devel@nongnu.org; Tue, 31 Jan 2012 03:30:25 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0V8UOdN018881
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 31 Jan 2012 03:30:24 -0500
Message-ID: <4F27A76D.7080109@redhat.com>
Date: Tue, 31 Jan 2012 09:33:49 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <20120124161628.4bf2592c@doriath.home>
	<4F1F0E9F.8080302@redhat.com> <4F1FC030.2030705@redhat.com>
	<20120125104204.55eec0a1@doriath.home>
	<20120126155757.3e97a0c1@doriath.home>
	<4F2273CF.3050107@redhat.com> <20120130131843.7f88117a@doriath>
	<4F26BA9A.1050705@redhat.com> <4F26BD84.3050403@redhat.com>
In-Reply-To: <4F26BD84.3050403@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

Am 30.01.2012 16:55, schrieb Paolo Bonzini:
> On 01/30/2012 04:43 PM, Kevin Wolf wrote:
>>>>>>
>>>>>>  If we had force=true in the initial eject command, bdrv_close is called,
>>>>>>  which in turn goes through bdrv_dev_change_media_cb where an event is
>>>>>>  emitted.
>>>>
>>>>  Can't this race with the guest eject?
>> Can't see how, there's nothing asynchronous in the path.
> 
> The button press is sent down to the guest even with -f.

Right, but there's no race. The guest will always be later.

Kevin