From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsERw-0001Lw-MC for qemu-devel@nongnu.org; Tue, 31 Jan 2012 09:12:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RsERn-00058g-1r for qemu-devel@nongnu.org; Tue, 31 Jan 2012 09:12:44 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:36924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsERm-00058X-Qk for qemu-devel@nongnu.org; Tue, 31 Jan 2012 09:12:35 -0500 Received: by pbaa11 with SMTP id a11so266671pba.4 for ; Tue, 31 Jan 2012 06:12:33 -0800 (PST) Message-ID: <4F27F6CD.1000807@codemonkey.ws> Date: Tue, 31 Jan 2012 08:12:29 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> In-Reply-To: <4F27E98E.2080501@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Mitsyanko Igor , Developers qemu-devel , KVM devel mailing list , quintela@redhat.com On 01/31/2012 07:15 AM, Andreas Färber wrote: > Am 31.01.2012 00:53, schrieb Anthony Liguori: >> On 01/30/2012 05:41 PM, Andreas Färber wrote: >>> Am 30.01.2012 19:55, schrieb Juan Quintela: >>>> Please send in any agenda items you are interested in covering. > >>> VMState: >>> Anthony specifically said that VMState were not affected by QOM and that >>> patches should not be deferred until the merge. Yet there's no review >>> and/or decision-making for a month now. Ping^2 for AHCI+SDHC. >> >> Do you have pointers (to pending VMState patches)? > > http://patchwork.ozlabs.org/patch/137732/ (PATCH v4) > > It's basically about how to deal with variable-sized arrays. (Alex > mentioned it on one call around November.) I found ways to deal with > subsets of arrays embedded within the struct and variable-sized list of > pointers to structs but no solution for a malloc()'ed array of structs. > Maybe I'm just too stupid to see. Anyway, no one commented since Xmas. /me puts on his flame proof suit Don't use VMState. Just open code a save/restore function. VMState is too limited in how it handles complex data structures. I really believe the only long term solution we're going to get to here is something that uses a builder interface (like Visitors). Regards, Anthony Liguori > > Igor posted (and refined for v2) a patch with a callback-based approach > that I find promising. From my view, unofficially Juan is the VMState > guy, he's been cc'ed. Are we lacking an official maintainer that cares? > Or is Juan the official, undocumented maintainer but simply busy? > > SUSE's interest is making AHCI migratable, and my VMState workaround for > that is simply ugly: > > http://patchwork.ozlabs.org/patch/133066/ (RFC) > > Therefore I'm waiting for some resolution. > > Regards, > Andreas >