From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsEmy-00008b-HM for qemu-devel@nongnu.org; Tue, 31 Jan 2012 09:34:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RsEmp-0000yC-66 for qemu-devel@nongnu.org; Tue, 31 Jan 2012 09:34:28 -0500 Received: from goliath.siemens.de ([192.35.17.28]:33920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsEmo-0000y4-R4 for qemu-devel@nongnu.org; Tue, 31 Jan 2012 09:34:19 -0500 Message-ID: <4F27FBE6.7040800@siemens.com> Date: Tue, 31 Jan 2012 15:34:14 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1327604460-31142-1-git-send-email-aliguori@us.ibm.com> <1327604460-31142-7-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1327604460-31142-7-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , Avi Kivity , Paolo Bonzini , qemu-devel@nongnu.org, Markus Armbruster On 2012-01-26 20:00, Anthony Liguori wrote: > @@ -548,6 +550,13 @@ static int piix3_realize(PCIDevice *dev) > /* Setup the RTC IRQ */ > s->rtc.irq = rtc_irq; > > + /* Realize the PIT */ > + qdev_set_parent_bus(DEVICE(&s->pit), BUS(s->bus)); > + qdev_init_nofail(DEVICE(&s->pit)); > + > + /* FIXME this should be refactored */ > + pcspk_init(ISA_DEVICE(&s->pit)); Fixing ATM, ie. converting to qdev/QOM. Q: How do I use qdev_property_add_link & Co. to establish the relation from the speaker port device to the PIT? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux