From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsF9w-0005Fg-Ix for qemu-devel@nongnu.org; Tue, 31 Jan 2012 09:58:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RsF9o-0007GJ-Ow for qemu-devel@nongnu.org; Tue, 31 Jan 2012 09:58:12 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:41253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsF9o-0007Ft-He for qemu-devel@nongnu.org; Tue, 31 Jan 2012 09:58:04 -0500 Received: by pbaa11 with SMTP id a11so309805pba.4 for ; Tue, 31 Jan 2012 06:58:03 -0800 (PST) Message-ID: <4F280177.4030007@codemonkey.ws> Date: Tue, 31 Jan 2012 08:57:59 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1327604460-31142-1-git-send-email-aliguori@us.ibm.com> <1327604460-31142-15-git-send-email-aliguori@us.ibm.com> <4F27FCD7.7050809@siemens.com> <4F27FFD3.9090107@codemonkey.ws> <4F280074.8010307@siemens.com> In-Reply-To: <4F280074.8010307@siemens.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Peter Maydell , Anthony Liguori , "qemu-devel@nongnu.org" , Markus Armbruster , Avi Kivity , Paolo Bonzini On 01/31/2012 08:53 AM, Jan Kiszka wrote: > On 2012-01-31 15:50, Anthony Liguori wrote: >> On 01/31/2012 08:38 AM, Jan Kiszka wrote: >>> On 2012-01-26 20:00, Anthony Liguori wrote: >>>> --- >>>> hw/pc.c | 70 ++++-------------------------------------------------- >>>> hw/pc.h | 3 +- >>>> hw/piix_pci.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++++- >>>> sysemu.h | 2 - >>>> 4 files changed, 79 insertions(+), 70 deletions(-) >>> >>> How does the ISA PC get its BIOS after this change? Or did that change >>> in a step I miss right now? >> >> Oh, I broke it. I made no attempt to keep ISA PC working. >> >> The way I'd like to handle this is to introduce a ROM device so that this code >> would be trivialized. > > Or just keep the common pc.c library as I voted for. It has its purpose, > obviously. Coding sharing needs to happen through device sharing. Otherwise we'll be stuck in the magic device creation through arbitrary functions rut that we currently find ourselves in. Regards, Anthony Liguori > > Jan >